Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new healthcheck config if not overridden #1801

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

piksel
Copy link
Member

@piksel piksel commented Oct 14, 2023

This PR will clear out the create container healthcheck configuration if it's equal to the original image's configuration. Doing this allows any new configuration from the updated image to be used instead.

Fixes #1601

@piksel piksel requested a review from simskij as a code owner October 14, 2023 11:44
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (72e437f) 69.23% compared to head (17efa77) 70.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1801      +/-   ##
==========================================
+ Coverage   69.23%   70.42%   +1.19%     
==========================================
  Files          26       26              
  Lines        2467     2482      +15     
==========================================
+ Hits         1708     1748      +40     
+ Misses        661      633      -28     
- Partials       98      101       +3     
Files Coverage Δ
pkg/container/container.go 71.01% <100.00%> (+15.28%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piksel piksel merged commit 40b8c77 into main Oct 21, 2023
12 checks passed
@piksel piksel deleted the fix/healthcheck-update branch October 21, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Healtcheck not updated
1 participant