feat: enabled loading http-api-token from file #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1728 +/- ##
==========================================
+ Coverage 67.59% 67.60% +0.01%
==========================================
Files 26 26
Lines 2379 2380 +1
==========================================
+ Hits 1608 1609 +1
Misses 672 672
Partials 99 99
☔ View full report in Codecov by Sentry. |
piksel
force-pushed
the
feat/api-token-file-secret
branch
from
2b4288c
to
58e9cd2
Compare
|
This is a great update. I'm going to try it right away. Thank you! |
|
Ok I see the new docker image isn't released yet. Are you planning to release it soon? |
|
You can try it using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
http-api-tokento the list of arguments that watchtower tries to load from a file if they exist (fixes #1711).Additionally, this adds some more (easier to find) docs about the usage (fixes #1390).