Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --health-check command line switch #1725

Merged
merged 6 commits into from
Sep 16, 2023

Conversation

bugficks
Copy link
Contributor

@bugficks bugficks commented Aug 9, 2023

This PR adds docker health check. Closes #1257

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07% 🎉

Comparison is base (79ebad0) 68.83% compared to head (246da4d) 68.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1725      +/-   ##
==========================================
+ Coverage   68.83%   68.90%   +0.07%     
==========================================
  Files          26       26              
  Lines        2448     2454       +6     
==========================================
+ Hits         1685     1691       +6     
  Misses        664      664              
  Partials       99       99              
Files Changed Coverage Δ
internal/flags/flags.go 86.87% <100.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@piksel piksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping out! I think we should help make this less of a foot-gun for the users though.

cmd/root.go Outdated Show resolved Hide resolved
docs/arguments.md Outdated Show resolved Hide resolved
docs/arguments.md Outdated Show resolved Hide resolved
internal/flags/flags.go Outdated Show resolved Hide resolved
@piksel piksel changed the title Add --health-check command line switch. feat: add --health-check command line switch Sep 16, 2023
@piksel piksel merged commit 8e3bde7 into containrrr:main Sep 16, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add healthcheck command
2 participants