Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update go version to 1.18 #1363

Merged
merged 8 commits into from
Sep 4, 2022
Merged

chore(deps): update go version to 1.18 #1363

merged 8 commits into from
Sep 4, 2022

Commits on Aug 21, 2022

  1. Create dependabot.yml

    @jauderho
    jauderho authored Aug 21, 2022
    Configuration menu
    Copy the full SHA
    9550071 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2022

  1. Merge branch 'containrrr:main' into main

    @jauderho
    jauderho authored Aug 28, 2022
    Configuration menu
    Copy the full SHA
    8cca19b View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. Update go.mod baseline to Go 1.18 

    Signed-off-by: Jauder Ho <[email protected]>
    @jauderho
    jauderho committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    d96db6f View commit details
    Browse the repository at this point in the history

  2. Update to use Go 1.18 

    Signed-off-by: Jauder Ho <[email protected]>
    @jauderho
    jauderho committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    72afe31 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2022

  1. replace golint with staticcheck 

    using go 1.18, the `go get` command does no longer install golint.
but since it's deprecated anyway, let's replace it with staticcheck
    @piksel
    piksel committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    4e94816 View commit details
    Browse the repository at this point in the history

  2. Merge branch upstream 'main' into jauderho/main

    @piksel
    piksel committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    6f655c6 View commit details
    Browse the repository at this point in the history

  3. go mod tidy

    @piksel
    piksel committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    437f2ca View commit details
    Browse the repository at this point in the history

  4. fix linting issues 

    internal/actions/mocks/progress.go:
- ineffective break statement. Did you mean to break out of the outer loop? (SA4011)
- redundant break statement (S1023)

pkg/container/client.go:
- should omit comparison to bool constant, can be simplified to execInspect.Running (S1002)
- error strings should not be capitalized (ST1005)

pkg/container/errors.go:
- var errorNoExposedPorts is unused (U1000)

pkg/registry/auth/auth.go:
- argument err is overwritten before first use (SA4009)
- the argument is already a string, there's no need to use fmt.Sprintf (S1025)

pkg/registry/trust.go:
- error strings should not be capitalized (ST1005)
    @piksel
    piksel committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    7a110c9 View commit details
    Browse the repository at this point in the history