Adds the --override-variant command line flag #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Man pages? |
Contributor
|
ACK to the Skopeo part (but it will need to update c/image to one that actually supports that flag). |
JirkaChadima
force-pushed
the
feat-override-variant
branch
from
379afbe to
f7c65d9
Compare
Signed-off-by: Jirka Chadima <[email protected]>
Signed-off-by: Jirka Chadima <[email protected]>
JirkaChadima
force-pushed
the
feat-override-variant
branch
from
f7c65d9 to
c6a731b
Compare
Member
|
@JirkaChadima @mtrmac @vrothberg Do we still need/want this PR? |
Contributor
Author
I'm fine without it, we have changed the pipeline for other reasons. But I still think it's a valuable addition to skopeo. |
Member
|
@sujil02 PTAL |
mtrmac
approved these changes
Mar 20, 2020
Contributor
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
LGTM. Thanks.
One other reviewer to sanity-check, please?
Member
|
I rebased to retrigger the tests; just to be sure. |
Contributor
|
@JirkaChadima Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #790 and can be merged only after containers/image#786 or containers/image#753
I'm not sure how dependencies work exactly in Go so I did not test this locally against the patched
containers/imageversion, but it should work once that dependency is updated.