Skip to content

Conversation

@mtrmac
Copy link
Contributor

@mtrmac mtrmac commented Sep 1, 2017

No description provided.

@mtrmac
Copy link
Contributor Author

mtrmac commented Sep 1, 2017

NOTE: This is somewhat of a time bomb in that it removes the capitalized Sirupsen/logrus from vendor.conf, but not from the vendor subdirectory; on macOS having both in vendor.conf breaks.

On rm -rf vendor; vdnr:

2017/09/02 01:30:21 Errors on clone:
github.com/Sirupsen/logrus: Err: exit status 128, out: fatal: destination path '/Users/mitr/Go/src/github.com/projectatomic/skopeo/vendor/github.com/Sirupsen/logrus' already exists and is not an empty directory.

On vndr with an existing directory structure (it gets more weird):

2017/09/02 01:29:31 Errors on clone:
github.com/sirupsen/logrus: Err: exit status 128, out: Cloning into '/Users/mitr/Go/src/github.com/projectatomic/skopeo/vendor/github.com/sirupsen/logrus'...
fatal: --stdin requires a git repository
fatal: index-pack failed

github.com/Sirupsen/logrus: Err: exit status 128, out: Cloning into '/Users/mitr/Go/src/github.com/projectatomic/skopeo/vendor/github.com/Sirupsen/logrus'...
error: could not lock config file /Users/mitr/Go/src/github.com/projectatomic/skopeo/vendor/github.com/Sirupsen/logrus/.git/config: No such file or directory
fatal: could not set 'remote.origin.fetch' to '+refs/heads/*:refs/remotes/origin/*'

Here’s hoping that opencontainers/image-tools#175 / opencontainers/image-tools#176 will be done soon…

Otherwise we would try to link with gpgme only for that unnecessary
workaround.
On macOS, (brew install gpgme) installs it within /usr/local, but
/usr/local/include is not in the default search path.

Rather than hard-code this directory, use gpgme-config. Sadly that
must be done at the top-level user instead of locally in the gpgme
subpackage, because cgo supports only pkg-config, not general shell
scripts, and gpgme does not install a pkg-config file.

If gpgme is not installed or gpgme-config can’t be found for other reasons,
the error is silently ignored (and the user will probably find out because
the cgo compilation will fail); this is so that users can use the
containers_image_openpgp build tag without seeing ugly errors
(and without the Makefile having to detect that build tag in even more
shell scripts).
@mtrmac
Copy link
Contributor Author

mtrmac commented Oct 2, 2017

@runcom PTAL. I have dropped the partial sirupsen/Sirupsen workaround in favor of handling that separately in #426.

@mtrmac mtrmac changed the title WIP DO NOT MERGE: Simplify macOS builds Simplify macOS builds Oct 2, 2017
@runcom
Copy link
Member

runcom commented Oct 3, 2017

LGTM

@runcom runcom merged commit 2966f79 into containers:master Oct 3, 2017
@mtrmac mtrmac deleted the macOS branch October 3, 2017 11:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants