Re-vendor, primarily for https://github.com/containers/storage/pull/11 #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
|
|
Contributor
Author
|
Yeah, I somehow managed to persuade git that there is a submodule. Hopefully fixed. (And no, we can’t trivially add a macOS target to Travis CI, because Travis does not support Docker on macOS. I suppose we could test |
Contributor
Author
|
@runcom tests pass now. |
Member
|
is there anyone willing to give this a try for MacOS? @hferentschik perhaps? |
mtrmac
force-pushed
the
storage-rebase
branch
2 times, most recently
from
37b7564 to
eb4395f
Compare
containers/storage got new dependencies, so we will need to re-vendor eventually anyway, and having this separate from other major work is cleaner. But the primary goal of this commit is to see whether it makes skopeo buildable on OS X.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
containers/storage got new dependencies, so we will need to re-vendor eventually anyway, and having this separate from other major work is cleaner.
But the primary goal of this commit is to see whether it makes skopeo buildable on OS X.