fix OCI image-spec dependency #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runcom
force-pushed
the
fix-image-spec-dep
branch
6 times, most recently
from
df0e48e to
3813c74
Compare
runcom
changed the title
Member
Author
|
@mtrmac revendored everything here, should be green now |
runcom
force-pushed
the
fix-image-spec-dep
branch
2 times, most recently
from
bc048cd to
003d973
Compare
Signed-off-by: Antonio Murdaca <[email protected]>
runcom
force-pushed
the
fix-image-spec-dep
branch
from
003d973 to
15b3fdf
Compare
Contributor
|
ACK. |
owtaylor
added a commit
to owtaylor/skopeo
that referenced
this pull request
Aug 21, 2017
org.opencontainers.image.ref.name values are allowed to be much more complex than the code allowed for. Change the validation to match the spec. Since ref-names can contain a :, split from the path on the first :, not the last :. (Path containing a : were already considered invalid.) fixes containers#294 Signed-off-by: Owen W. Taylor <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to validate containers/image#223 vendoring containers/image#223 from my own branch.
Signed-off-by: Antonio Murdaca [email protected]