Complete bash completions for skopeo #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
runcom
reviewed
Nov 30, 2016
completions/bash/skopeo
Outdated
|
|
||
| _skopeo_skopeo() { | ||
| local options_with_args=" | ||
| --username |
Member
Author
There was a problem hiding this comment.
Ok, I will remove them once I have this merged.
Member
There was a problem hiding this comment.
Ok, I will remove them once I have this merged.
Do you want this PR merged first? cause I already merged #254 😄
rhatdan
force-pushed
the
bash_completions
branch
from
8204cec to
d34d59f
Compare
Member
Author
|
A little script I wrote to check for options: |
Member
Author
|
Updated to match #254 |
Member
|
LGTM |
Member
|
@rhatdan could you rebase this one and I'll merge? |
Current code only handled commands not the options.
rhatdan
force-pushed
the
bash_completions
branch
from
d34d59f to
6dc3648
Compare
Member
Author
|
Rebased. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code only handled commands not the options.