Support layers federation #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runcom
force-pushed
the
layers-federation
branch
from
dd2e328 to
77b71b8
Compare
Member
|
LTM |
mtrmac
reviewed
Nov 25, 2016
cmd/skopeo/layers.go
Outdated
| digest = "sha256:" + digest | ||
| } | ||
| r, blobSize, err := rawSource.GetBlob(digest) | ||
| r, blobSize, err := rawSource.GetBlob(types.BlobInfo{Digest: digest}) |
Contributor
There was a problem hiding this comment.
This should probably set Size to -1 (unknown), depending on how #147 defines the GetBlob requirements.
runcom
force-pushed
the
layers-federation
branch
4 times, most recently
from
72aaea6 to
3ff64dc
Compare
Signed-off-by: Antonio Murdaca <[email protected]>
runcom
force-pushed
the
layers-federation
branch
from
3ff64dc to
f36fde9
Compare
Member
Author
|
@mtrmac PTAL |
Member
Author
|
@mtrmac merging because there's only one tiny small changes here in skopeo to unblock PRs in containers/image (that otherwise fails) |
Contributor
|
ACK to the layers fix, but please redo without the |
Member
Author
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on containers/image#147
Signed-off-by: Antonio Murdaca [email protected]