Refer to the policy file as a trust policy file. #192
Conversation
|
Fixes #191 |
cmd/skopeo/copy.go
Outdated
| trustContext, err := getTrustContext(context) | ||
| if err != nil { | ||
| return fmt.Errorf("Error loading verification policy: %v", err) | ||
| return fmt.Errorf("Error loading trust verification: %v", err) |
There was a problem hiding this comment.
I am not a native speaker but “trust verification” does not make much sense to me. How do you load a "verification”?
There was a problem hiding this comment.
I agree, I was just throwing this together for discussion. I liked this slightly better the
Error loading verification trust.
"Error loading trust policy" is probably ok.
|
I am perfectly fine with renaming |
|
I think we can drop this back and just leave policy in lots of places but begin talking about it as a "trust" policy. @aweiteka WDYT? |
|
The two really user-visible pieces to which we kind of commit to in the public release are the I am perfectly fine with changing these two to |
|
I simplified the original pull request to just change the way we refer to the file, as a trust policy file. Lets talk at the meeting. |
rhatdan
changed the title
|
Fixes #191 |
The policy file is actualy indicatiting the signatures that the user trusts. This patch changes the documentation and error messages to indicate this trust.
|
LGTM as is (@mtrmac?) |
|
ACK. A similar patch to containers/image would touch 3 error messages. |
3 participants
No description provided.