Merged
Conversation
Contributor
|
I guess it would be cleanest to have a single PR which vendors this as one commit, and then the appropriate version of |
Member
Author
|
This should fix most of the problem that's keeping the test for containers/image#63 from passing, but I think it still needs to conditionally define the btrfs_noversion and libdm_no_deferred_remove build tags. |
nalind
force-pushed
the
vendor-storage
branch
9 times, most recently
from
e38c195 to
2618f32
Compare
nalind
force-pushed
the
vendor-storage
branch
4 times, most recently
from
8b17e31 to
3accac6
Compare
nalind
force-pushed
the
vendor-storage
branch
2 times, most recently
from
19f11a4 to
e8782d9
Compare
nalind
force-pushed
the
vendor-storage
branch
3 times, most recently
from
c354855 to
a55ff1e
Compare
Member
|
Is this still being worked on? |
nalind
force-pushed
the
vendor-storage
branch
from
a55ff1e to
37f82b1
Compare
Member
Author
|
@rhatdan Yes, the PR is current. |
Member
Member
|
@rhatdan we need to first merge containers/image#63 and that's pending review by Miloslav |
Member
|
Ok we just need him to make sure nothing in Signatures gets broken. |
nalind
force-pushed
the
vendor-storage
branch
2 times, most recently
from
f6fd42f to
1182a23
Compare
nalind
force-pushed
the
vendor-storage
branch
from
1182a23 to
92c6766
Compare
nalind
force-pushed
the
vendor-storage
branch
2 times, most recently
from
40ca40c to
3141455
Compare
When we start up, initialize handlers so that we can import blobs correctly when using the storage library. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
vendor-storage
branch
2 times, most recently
from
14a8e51 to
a9b2917
Compare
Vendor containers/storage, and its dependencies github.com/pborman/uuid and github.com/mistifyio/go-zfs, which we didn't already use. Update the build Dockerfile to install their dependencies. Add scriptlets that try to detect whether or not we need to use the "libdm_no_deferred_remove" and/or "btrfs_noversion" build tags. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
vendor-storage
branch
from
a9b2917 to
4960f39
Compare
Member
Author
|
Updated to pull in the current version of containers/image as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendor containers/storage, and its dependencies github.com/mistifyio/go-zfs and github.com/pborman/uuid.