Drop all capablities and run with no-new-privileges

[rhatdan]

llama-run attempts to write to $HOME. Since we are running as root inside of the container, the process tries to write to /root which is has permissions 500, which means even root procesess can not write their without CAP_DAC_OVERRIDE, since we don't want to give that CAP, we modify HOME to be /tmp/

Summary by Sourcery

Enhancements:

• Prevent the container from writing to /root by setting the HOME environment variable to /tmp. This avoids the need for the CAP_DAC_OVERRIDE capability.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request updates the container initialization logic in the model setup to improve security by dropping all capabilities and enforcing no-new-privileges. It also sets the HOME environment variable to /tmp to avoid permission issues when running as root.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Enhanced container security configuration during startup.	Added --env=HOME=/tmp to set the HOME environment variable to /tmp. Included --cap-drop=all to remove all capabilities. Added --security-opt=no-new-privileges to prevent new privilege escalation.	ramalama/model.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @rhatdan - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider grouping the added security options into a dedicated variable for improved clarity and maintainability.
• Verify that resetting HOME to /tmp doesn't affect any subprocesses or scripts expecting the usual path.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[ericcurtin]

Looks fine... I'm not very well versed in this stuff, but this won't kill the GPU acceleration, like the interactions with /dev/dri and /dev/kfd (for ROCm)?

[ericcurtin]

I suspect what "podman run" does and what our generators do for quadlet, k8s, etc. Might have drifted also

[rhatdan]

Should work fine for GPUs only an issue if the Capability would be required. The point about generators is true.