Skip to content

Update default llama.cpp commit hash to b8323.#2515

Closed
cthach wants to merge 1 commit intocontainers:mainfrom
cthach:patch-1
Closed

Update default llama.cpp commit hash to b8323.#2515
cthach wants to merge 1 commit intocontainers:mainfrom
cthach:patch-1

Conversation

@cthach
Copy link

@cthach cthach commented Mar 14, 2026

View the release tag.

See diff since the last commit hash for more info.

Summary by Sourcery

Build:

  • Bump the pinned llama.cpp Git commit in the container build script from b8256 to b8323.

Signed-off-by: Chris Thach <git.identify957@passfwd.com>
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 14, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the default pinned llama.cpp commit hash used by the container build script to point from commit b8256 to b8323, ensuring container images build against the newer upstream version.

File-Level Changes

Change Details Files
Update the default pinned llama.cpp commit hash used during container image builds to a newer upstream revision.
  • Change DEFAULT_LLAMA_CPP_COMMIT to the new git SHA corresponding to upstream tag/commit b8323
  • Keep all other build parameters (e.g., MESA_VULKAN_VERSION and helper functions) unchanged
container-images/scripts/build_llama.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the default llama.cpp commit hash referenced in the build script. This change ensures that any new container images built will utilize a more recent version of the llama.cpp project, thereby incorporating the latest upstream developments, optimizations, and bug fixes.

Highlights

  • llama.cpp Commit Hash Update: The DEFAULT_LLAMA_CPP_COMMIT variable in the build_llama.sh script has been updated from f76565db92272d98976d5b8b1809ebe1e079f8cd (b8256) to 57819b8d4b39d893408e51520dff3d47d1ebb757 (b8323).

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default llama.cpp commit hash to a newer version. The change is straightforward, modifying a single variable in the build_llama.sh script. The update appears correct and consistent with how dependencies are managed in this project. I have no further comments or suggestions.

@mikebonnet
Copy link
Collaborator

Is there a specific fix you're looking for this update?

@cthach cthach temporarily deployed to macos-installer March 14, 2026 00:51 — with GitHub Actions Inactive
@mikebonnet
Copy link
Collaborator

/ok-to-test

@cthach
Copy link
Author

cthach commented Mar 14, 2026

Is there a specific fix you're looking for this update?

Yes, this one ggml-org/llama.cpp#20416 🙏🏾

Sure I can just build it myself but it took less than a min to open this PR

@olliewalsh
Copy link
Collaborator

Was planning to bump this once ggml-org/llama.cpp#20518 lands

@olliewalsh
Copy link
Collaborator

Closing this - maintainers manage bumping llama.cpp. Please raise an issue instead if there is a specific issue.

@olliewalsh olliewalsh closed this Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants