Skip to content

:latest tag should not be assumed for non-OCI artefacts #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

:latest tag should not be assumed for non-OCI artefacts #1534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ramalama/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,8 @@ def _list_models_from_store(args):

if model.startswith("huggingface://"):
model = model.replace("huggingface://", "hf://", 1)

if not model.startswith("ollama://") and not model.startswith("oci://"):
model = model.removesuffix(":latest")

size_sum = 0
Expand Down
4 changes: 2 additions & 2 deletions test/system/050-pull.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ load setup_suite
run_ramalama pull $file_url
run_ramalama list
# remove the additional slash character
expected_url=$(sed "s/file\:\//file\:/" <<< $file_url):latest
expected_url=$(sed "s/file\:\//file\:/" <<< $file_url)
is "$output" ".*$expected_url" "URL exists"
run_ramalama rm $file_url
run_ramalama list
Expand All @@ -163,7 +163,7 @@ load setup_suite
touch $model
url=file://${model}
# remove the additional slash character
expected_url=$(sed "s/file\:\//file\:/" <<< $url):latest
expected_url=$(sed "s/file\:\//file\:/" <<< $url)

run_ramalama pull $url
run_ramalama list
Expand Down
Loading