-
Notifications
You must be signed in to change notification settings - Fork 270
chore: bump 'ramalama-stack' version to 0.2.0 #1478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Weinberg <[email protected]>
Reviewer's GuideThis PR updates the Llama Stack Containerfile to use ramalama-stack version 0.2.0 by revising both the remote asset URLs and the pip installation command accordingly. Sequence Diagram: Fetching ramalama-stack v0.2.0 Artifacts during Image BuildsequenceDiagram
participant BuildProcess as Container Build Process
participant GitHub
participant PyPI
BuildProcess->>+GitHub: GET .../ramalama-stack/refs/tags/v0.2.0/.../ramalama.yaml
GitHub-->>-BuildProcess: ramalama.yaml (v0.2.0)
BuildProcess->>+GitHub: GET .../ramalama-stack/refs/tags/v0.2.0/.../ramalama-run.yaml
GitHub-->>-BuildProcess: ramalama-run.yaml (v0.2.0)
BuildProcess->>+PyPI: uv pip install ramalama-stack==0.2.0
PyPI-->>-BuildProcess: ramalama-stack package (0.2.0)
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
cdoern
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nathan-weinberg - I've reviewed your changes - here's some feedback:
- Consider parameterizing the ramalama-stack version as a build ARG so you don’t have to update multiple RUN commands when bumping the version.
- The pip install constraint changed from
>=1.5.0to==0.2.0—if you want to allow future patch updates, consider using a range like>=0.2.0,<0.3.0instead of a strict==.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
rhatdan
reviewed
Jun 5, 2025
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Bump ramalama-stack to version 0.2.0 in the llama-stack container image
Build: