Skip to content

Conversation

@nathan-weinberg
Copy link
Collaborator

@nathan-weinberg nathan-weinberg commented Jun 5, 2025

Summary by Sourcery

Bump ramalama-stack to version 0.2.0 in the llama-stack container image

Build:

  • Update remote YAML fetch URLs to references v0.2.0
  • Pin pip installation of ramalama-stack to ==0.2.0

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 5, 2025

Reviewer's Guide

This PR updates the Llama Stack Containerfile to use ramalama-stack version 0.2.0 by revising both the remote asset URLs and the pip installation command accordingly.

Sequence Diagram: Fetching ramalama-stack v0.2.0 Artifacts during Image Build

sequenceDiagram
    participant BuildProcess as Container Build Process
    participant GitHub
    participant PyPI

    BuildProcess->>+GitHub: GET .../ramalama-stack/refs/tags/v0.2.0/.../ramalama.yaml
    GitHub-->>-BuildProcess: ramalama.yaml (v0.2.0)
    BuildProcess->>+GitHub: GET .../ramalama-stack/refs/tags/v0.2.0/.../ramalama-run.yaml
    GitHub-->>-BuildProcess: ramalama-run.yaml (v0.2.0)
    BuildProcess->>+PyPI: uv pip install ramalama-stack==0.2.0
    PyPI-->>-BuildProcess: ramalama-stack package (0.2.0)
Loading

File-Level Changes

Change Details Files
Bump ramalama-stack version to 0.2.0
  • Update remote inference YAML URL to tag v0.2.0
  • Update ramalama-run YAML URL to tag v0.2.0
  • Pin pip install to ramalama-stack==0.2.0
container-images/llama-stack/Containerfile

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nathan-weinberg - I've reviewed your changes - here's some feedback:

  • Consider parameterizing the ramalama-stack version as a build ARG so you don’t have to update multiple RUN commands when bumping the version.
  • The pip install constraint changed from >=1.5.0 to ==0.2.0—if you want to allow future patch updates, consider using a range like >=0.2.0,<0.3.0 instead of a strict ==.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rhatdan
Copy link
Member

rhatdan commented Jun 5, 2025

LGTM

@nathan-weinberg nathan-weinberg merged commit 268e47c into containers:main Jun 5, 2025
15 of 16 checks passed
@nathan-weinberg nathan-weinberg deleted the stack-bump branch June 5, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants