Skip to content

Conversation

@kpouget
Copy link
Collaborator

@kpouget kpouget commented May 20, 2025

This PR adds the ggml-vulkan backend image to the images built by Ramalama, until this backend becomes part of the default image.

Build tested locally with the Fedora base image (I don't access the UBI image on this machine)

Summary by Sourcery

Build:

  • Add Containerfile for the ggml-vulkan backend image based on Fedora 42

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 20, 2025

Reviewer's Guide

Adds a new Vulkan-specific container image by introducing a dedicated Containerfile that uses Fedora 42, copies the existing build scripts, and invokes them to build the llama and whisper binaries with the Vulkan backend.

File-Level Changes

Change Details Files
Introduce a new Containerfile to build the Vulkan image
  • Use Fedora 42 as the base image
  • Copy existing scripts into /usr/bin with executable permissions
  • Run the build_llama_and_whisper.sh script with "vulkan" argument
container-images/vulkan/Containerfile

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kpouget - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Copying from a parent directory may violate Docker build context rules (link)
Here's what I looked at during the review
  • 🔴 General issues: 1 blocking issue, 1 other issue
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@kpouget kpouget changed the title Build a Vulkan image WIP: Build a Vulkan image May 20, 2025
@kpouget kpouget changed the title WIP: Build a Vulkan image Build a Vulkan image May 20, 2025
@ericcurtin
Copy link
Member

We are better off just waiting a few days until podman desktop takes on podman 5.5 and then we will switch the main ramalama container image to GGML_VULKAN ... We want to use @slp's mesa with some page size patches also... It's also one less container image to maintain...

@rhatdan
Copy link
Member

rhatdan commented May 22, 2025

We can make the switch next week.

@rhatdan rhatdan closed this May 22, 2025
@kpouget kpouget deleted the vulkan branch June 17, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants