-
Notifications
You must be signed in to change notification settings - Fork 270
Build a Vulkan image #1429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build a Vulkan image #1429
Conversation
Reviewer's GuideAdds a new Vulkan-specific container image by introducing a dedicated Containerfile that uses Fedora 42, copies the existing build scripts, and invokes them to build the llama and whisper binaries with the Vulkan backend. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kpouget - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Copying from a parent directory may violate Docker build context rules (link)
Here's what I looked at during the review
- 🔴 General issues: 1 blocking issue, 1 other issue
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Kevin Pouget <[email protected]>
…packages for the vulkan image
|
We are better off just waiting a few days until podman desktop takes on podman 5.5 and then we will switch the main ramalama container image to GGML_VULKAN ... We want to use @slp's mesa with some page size patches also... It's also one less container image to maintain... |
|
We can make the switch next week. |
This PR adds the
ggml-vulkanbackend image to the images built by Ramalama, until this backend becomes part of the default image.Build tested locally with the Fedora base image (I don't access the UBI image on this machine)
Summary by Sourcery
Build: