-
Notifications
You must be signed in to change notification settings - Fork 272
python package fixes #1411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python package fixes #1411
Conversation
Going to switch libexec files to just bin ones. There are breakages because the python installers are not updating the shebangs in the libexec files, moving to bin solves this. Signed-off-by: Eric Curtin <[email protected]>
Reviewer's GuideThis PR migrates the CLI entrypoints out of libexec into standard bin scripts by updating project.scripts in pyproject.toml, removing the outdated libexec include block, and renaming the executable files to proper Python modules under the package to ensure shebang updates work correctly. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ericcurtin - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Is this still active, or should we close and open a new one? |
|
A friendly reminder that this PR had no activity for 30 days. |
|
Since these files no longer exist, closing. |
Going to switch libexec files to just bin ones.
There are breakages because the python installers are not updating the shebangs in the libexec files, moving to bin solves this.
Summary by Sourcery
Switch core command scripts from libexec to entry points in pyproject.toml to ensure proper shebang updates by Python installers
Bug Fixes:
Enhancements: