Skip to content

Conversation

@dougsland
Copy link
Member

@dougsland dougsland commented Apr 30, 2025

Be compatible with both versions of nvidia-smi
with version flag or not.

Resolves: #1308

Summary by Sourcery

Enhancements:

  • Adjust nvidia-smi command to work with both version flag and default output

Be compatible with both versions of nvidia-smi
with version flag or not.

Signed-off-by: Douglas Landgraf <[email protected]>
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 30, 2025

Reviewer's Guide

This pull request updates the check_cuda_version function by removing the --version flag from the nvidia-smi command, allowing it to parse the CUDA version from the default command output for compatibility with different nvidia-smi versions.

File-Level Changes

Change Details Files
Removed --version flag from nvidia-smi command for compatibility.
  • Modified the command list passed to run_cmd in check_cuda_version to invoke nvidia-smi without arguments.
ramalama/common.py

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dougsland - I've reviewed your changes - here's some feedback:

  • Consider trying nvidia-smi --version first and falling back to nvidia-smi without flags if the first command fails, to explicitly handle both cases.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rhatdan
Copy link
Member

rhatdan commented Apr 30, 2025

LGTM

@rhatdan rhatdan merged commit 21257c3 into containers:main Apr 30, 2025
14 of 15 checks passed
@rhatdan
Copy link
Member

rhatdan commented Apr 30, 2025

Thanks @dougsland

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RuntimeError: CUDA version (0, 0) is not supported. Minimum required version is 12.4.

2 participants