-
Notifications
You must be signed in to change notification settings - Fork 271
common: adjust nvidia-smi for check cuda version #1311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Be compatible with both versions of nvidia-smi with version flag or not. Signed-off-by: Douglas Landgraf <[email protected]>
Reviewer's GuideThis pull request updates the File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dougsland - I've reviewed your changes - here's some feedback:
- Consider trying
nvidia-smi --versionfirst and falling back tonvidia-smiwithout flags if the first command fails, to explicitly handle both cases.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
LGTM |
|
Thanks @dougsland |
Be compatible with both versions of nvidia-smi
with version flag or not.
Resolves: #1308
Summary by Sourcery
Enhancements: