Fix handling of entrypoint for Intel

[rhatdan]

Summary by Sourcery

Fix entrypoint handling for Intel container images

Bug Fixes:

• Remove explicit empty entrypoint setting in container runtime arguments to resolve potential container startup issues

Chores:

• Update Containerfile to remove unnecessary ENTRYPOINT declaration

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request modifies the container image build process to avoid setting an entrypoint and removes the entrypoint argument from the container manager arguments. This change was made to fix handling of entrypoint for Intel.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Modified the container image build process to avoid setting an entrypoint.	Added an empty entrypoint instruction to the container image build process.	container-images/cuda/Containerfile
Removed the entrypoint argument from the container manager arguments.	Removed the entrypoint argument.	ramalama/model.py

Possibly linked issues

• Resolve undefined errors in huggingface.py and model.py #123: The PR fixes the issue by adding ENTRYPOINT=[], addressing the missing ENTRYPOINT in Docker.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[rhatdan]

@lirc572 could you check to see if this fixes your problem with intel-gpu?

[sourcery-ai]

Hey @rhatdan - I've reviewed your changes - here's some feedback:

Overall Comments:

• Removing the entrypoint in model.py and setting it to empty in the Containerfile seems like a big change - is this really what you intended?

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[rhatdan]

Tested the cuda change and it looks good to me.

[ericcurtin]

vllm is broken now as their two entrypoints are different for rocm and cuda

But vllm is broken anyway...

[rhatdan]

@lirc572 PTAL

[lirc572]

You missed the intel-gpu/entrypoint.sh file.

[rhatdan]

@lirc572 It is there now.

[lirc572]

Looks good!

[rhatdan]

Just got to get by shellcheck and then we can merge. (And release)

[rhatdan]

The intel image has been updated on quay.io/ramalama/intel-gpu with the fixes.

[lirc572]

The intel image has been updated on quay.io/ramalama/intel-gpu with the fixes.

Tried it. Works great!