-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPM: remove user_namespace
for c9s in qm.spec
#93
Conversation
@dougsland builds passed here. PTAL |
Copr builds occur in a mock chroot on a Fedora host. So Makefile checks for /sys/fs/selinux/class/user_namespace may suffice for local builds on c9s, but won't work alone for Copr builds. This patch will remove `user_namespace` from qm.if for all c9s/rhel environments. Signed-off-by: Lokesh Mandvekar <[email protected]>
we could either do it this way or perhaps check in the Makefile for |
@dougsland @Yarboa feel free to merge this to get things unblocked. Only affects rpms on c9s (if at all). @rhatdan might be occupied with devconf.cz . |
@lsm5 could you please confirm if this helps keep the logic in the makefile:
|
Of course, using TAB as space. It's bad indentation here. |
RE: Makefile, do we see this condition hitting environments other than CI / copr / koji environments? I got no strong opinion on this btw. grepping for that string works, but may want to grep for |
sure |
LGTM |
Copr builds occur in a mock chroot on a Fedora host. So Makefile checks
for /sys/fs/selinux/class/user_namespace may suffice for local builds on
c9s, but won't work alone for Copr builds.
This patch will remove
user_namespace
from qm.if for all c9s/rhelenvironments.