Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr_77 #82

Merged
merged 5 commits into from
Jun 8, 2023
Merged

Pr_77 #82

merged 5 commits into from
Jun 8, 2023

Conversation

Yarboa
Copy link
Collaborator

@Yarboa Yarboa commented Jun 7, 2023 •
edited
Loading

Resolve #72

During the push to this PR PR has closed, can not reopen
Proposing new PR instead of this

#77

@Yarboa Yarboa requested review from rhatdan, lsm5 and dougsland as code owners June 7, 2023 12:58
@rhatdan
Copy link
Member

rhatdan commented Jun 7, 2023

Please fix the DCO

@dougsland
Copy link
Collaborator

Thanks @adityakode @Yarboa. As Dan mentioned, fix DCO and we should be fine.

@Yarboa Yarboa force-pushed the PR_77 branch 2 times, most recently from ed7e2ab to f54ad7e Compare June 7, 2023 13:35
@Yarboa Yarboa mentioned this pull request Jun 7, 2023
Closed
Yarboa and others added 3 commits June 7, 2023 16:40
@Yarboa
Rebase with latest changes
bcfeb88 
Signed-off-by: Yariv Rachmani <[email protected]>
@Yarboa
Fixes based on test run
6ac25aa 
Had issues with Array env variables in tmt
Propose some minor changes in e2e/lib/test

Signed-off-by: Yariv Rachmani <[email protected]>
@adityakode @Yarboa
Changed ContainerFile.control to ContainerFile.template
53b2511 
Signed-off-by: Aditya Kode <[email protected]>
Signed-off-by: Yariv Rachmani <[email protected]>
Yarboa
Yarboa commented Jun 7, 2023
View reviewed changes
Copy link
Collaborator Author

@Yarboa Yarboa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e i failing on this, Please fix
Error: stat /var/ARTIFACTS/work-tier-0zbew6jc9/tests/e2e/tier-0/tree/tests/e2e/ContainerFile.template: no such file or directory

@dougsland I will let you know once ready

@lsm5
Copy link
Member

lsm5 commented Jun 7, 2023

LGTM pending testing-farm task and commit squashing.

@dougsland
Copy link
Collaborator

wow now is cool to see that testing-farm tests is real thing, it detected this one:

�[33m[13:45:33] [W] [worker_0] [stderr] [CentOS-Stream-9:x86_64:/tests/e2e/tier-0] stderr (2 lines)�[0m
�[33m[13:45:33] [W] [worker_0] [stderr] [CentOS-Stream-9:x86_64:/tests/e2e/tier-0] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
�[33m[13:45:33] [W] [worker_0] [stderr] [CentOS-Stream-9:x86_64:/tests/e2e/tier-0] Error: stat /var/ARTIFACTS/work-tier-0zbew6jc9/tests/e2e/tier-0/tree/tests/e2e/ContainerFile.template: no such file or directory�[0m


�[33m[13:45:33] [W] [worker_0] [stderr] [CentOS-Stream-9:x86_64:/tests/e2e/tier-0] Error: repository name must have at least one component�[0m
�[33m[13:45:33] [W] [worker_0] [stderr] [CentOS-Stream-9:x86_64:/tests/e2e/tier-0] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
�[33m[13:45:33] [W] [worker_0] [stderr] [CentOS-Stream-9:x86_64:/tests/e2e/tier-0] �[0m
�[32m[13:45:33] [+] ---^---^---^---^---^--- End of command output�[0m

Looks like it's missing: ContainerFile.template: no such file or directory�[0m

dougsland
dougsland requested changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@dougsland dougsland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we need more changes, @Yarboa please take a look.

dougsland
dougsland requested changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@dougsland dougsland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we need more changes, @Yarboa please take a look.

dougsland
dougsland requested changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@dougsland dougsland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we need more changes, @Yarboa please take a look.

Yarboa
Yarboa commented Jun 8, 2023
View reviewed changes
Copy link
Collaborator Author

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is failing on first container, since it takes it more then 5 seconds
Have to add
https://github.com/containers/qm/blob/main/tests/e2e/lib/systemd#L117

Here a check about the output or wait time our

tests/e2e/lib/container Outdated Show resolved Hide resolved
adityakode and others added 2 commits June 8, 2023 15:39
@adityakode @Yarboa
Create ContainerFile.template
f15955a 
Adding the Fix for container location

Signed-off-by: Yariv Rachmani <[email protected]>
@Yarboa
Adding wait mechanism for containers
27ad740 
Currently test is failing since the container-safety.service
Is booting slow

Signed-off-by: Yariv Rachmani <[email protected]>
@Yarboa Yarboa requested a review from dougsland June 8, 2023 12:41
@dougsland
Copy link
Collaborator

LGTM
lets' fly!

@dougsland dougsland merged commit 9124842 into containers:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougsland dougsland dougsland approved these changes

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@lsm5 lsm5 Awaiting requested review from lsm5 lsm5 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

e2e tool: transform ContainerFile.control to ContainerFile.template
5 participants
@Yarboa @rhatdan @dougsland @lsm5 @adityakode