-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a documentation regarding networking options on QM #713
Conversation
Reviewer's Guide by SourceryThis pull request adds a new documentation file that explains the networking options in Podman. The documentation details the 'host' and 'private' networking modes, highlights the security implications of using the host network, and reinforces that 'private' is the default mode due to security reasons. An example usage is also provided to illustrate the difference between these modes. Flow Diagram for Podman Networking Optionsflowchart TD
A[Run Podman Container Command] --> B{Is --network flag specified?}
B -- "--network=host" --> C[Container uses host network stack]
C --> D[Shares host's network interfaces, IP addresses, ports]
D --> E[Exposes sensitive network resources]
E --> F[Security risks: container escape, lateral movement]
B -- "--network not specified or set to private" --> G[Container uses isolated network namespace]
G --> H[Communicates only with containers on the same network]
H --> I[Security enforced by default]
style E fill:#f88,stroke:#333,stroke-width:2px
style I fill:#afa,stroke:#333,stroke-width:2px
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
27ff3de
to
ad48599
Compare
@nsednev like this in qm: podman exec qm cat /etc/containers/systemd/nginx.container Then curl inside QM with different Network values |
AFAIK Quadlets are a type of configuration file used by the qm command in Podman to manage containers. A quadlet file is a text file that contains a set of key-value pairs that define the configuration for a container. In this ticket I was asked to document specific network options, rather than to create configuration files. |
I think the missing part here is about the qm network
I will try to explain, related this doc. which is under docs/tutorials/networking.md of qm I assume binding a context to QM is missing |
This readme was created after I discussed it with @dougsland and according to our discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use fedora not ubuntu.
I agree it's useful change but let's open a different issue for that so @nsednev can work and improve the doc. |
…ality with default settings of private because of security enforcements. Signed-off-by: nsednev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made changes as requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dougsland Made changes as requested.
…ality with default settings of private because of security enforcements. Signed-off-by: nsednev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nsednev - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a section on how to create and manage custom networks in Podman.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@nsednev could you please add in another patch a link from the main README.md to this documentation ? Like "Network session in the README" |
Added NETWORK.md explaining network=host and network=private functionality with default settings of private because of security enforcement.
explained what happens if you change network=host and network=private
and explained that by default it's private
because of security enforcement
I took more information from https://github.com/containers/podman/blob/main/docs/tutorials/basic_networking.md
Summary by Sourcery
Document the networking options for Podman, explaining the "host" and "private" modes and the security implications of each.
New Features:
Documentation: