Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Packit test tmt plans #69

Merged
merged 3 commits into from
May 31, 2023
Merged

Add Packit test tmt plans #69

merged 3 commits into from
May 31, 2023

Conversation

Yarboa
Copy link
Collaborator

@Yarboa Yarboa commented May 23, 2023

TMT plan to be used by TestingFarm

Propose framework to run github actions on TestingFarm
please follow this article
https://fedoramagazine.org/test-github-projects-with-github-actions-and-testing-farm/

@Yarboa Yarboa requested review from rhatdan and lsm5 as code owners May 23, 2023 15:12
@Yarboa Yarboa changed the title Tmt tests [Draft] Tmt tests May 23, 2023
@Yarboa Yarboa marked this pull request as draft May 23, 2023 15:13
@Yarboa Yarboa force-pushed the tmt-tests branch 6 times, most recently from 8ae9aa8 to 6a9e566 Compare May 25, 2023 11:08
@rhatdan
Copy link
Member

rhatdan commented May 26, 2023

LGTM
@dougsland @cevich @lsm5 PTAL

@lsm5
Copy link
Member

lsm5 commented May 26, 2023

@Yarboa can we get this hooked into packit with entries in .packit.yaml ? That way they could start running from this very PR and we get a more visual idea.

@lsm5
Copy link
Member

lsm5 commented May 26, 2023

@Yarboa can we get this hooked into packit with entries in .packit.yaml ? That way they could start running from this very PR and we get a more visual idea.

@Yarboa see: https://packit.dev/docs/testing-farm/

@Yarboa Yarboa force-pushed the tmt-tests branch 6 times, most recently from 35da589 to c132862 Compare May 29, 2023 18:57
@Yarboa
Copy link
Collaborator Author

Yarboa commented May 29, 2023

@Yarboa can we get this hooked into packit with entries in .packit.yaml ? That way they could start running from this very PR and we get a more visual idea.

@Yarboa see: https://packit.dev/docs/testing-farm/

@lsm5 checking

@packit-as-a-service
Copy link

Failed to load packit config file:

Cannot parse package config: ValidationError({'jobs': {3: {'job': ['Invalid enum member e2e_tests']}}}).

For more info, please check out the documentation or contact the Packit team.

@Yarboa Yarboa force-pushed the tmt-tests branch 2 times, most recently from 1731077 to 325cbaf Compare May 30, 2023 12:56
@Yarboa Yarboa changed the title [Draft] Tmt tests Add Packit test tmt plans May 30, 2023
@lsm5
Copy link
Member

lsm5 commented May 30, 2023

@Yarboa great, maybe it's worth adding fedora tasks too while we're at it?

@Yarboa Yarboa self-assigned this May 30, 2023
@Yarboa Yarboa marked this pull request as ready for review May 30, 2023 13:27
@Yarboa Yarboa requested a review from dougsland as a code owner May 30, 2023 13:27
Yarboa
Yarboa commented May 30, 2023
View reviewed changes
.packit.yaml Show resolved Hide resolved
cevich
cevich reviewed May 30, 2023
View reviewed changes
Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert in packit or TMT so please take my suggestions with a measure of salt.

.packit.yaml
@@ -84,3 +92,4 @@ jobs:
# Disable bodhi for epel-9 until hirte and podman 4.5 are available
# Ref: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-77d64cf134#comment-3026157
#- epel-9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A "TODO" in a hidden file seems ripe to be forgotten. Consider if it would be helpful to open an issue on this, and link the issue in the comment (above).

tests/e2e/tier-0.fmf Outdated
@@ -0,0 +1,35 @@
summary: Tier 0 - QM Interconnect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the off-chance a non-expert looks at this: I would suggest adding a comment at the start of this file with a link to the documentation for the file format.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, see README. md UPDATE in the PR

tests/qm-connectivity/main.fmf Outdated
@@ -0,0 +1,12 @@
summary: Concise summary describing what the test does
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also suggest adding comment w/ link to format docs.

Copy link
Collaborator Author

@Yarboa Yarboa May 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, see README. md UPDATE in the PR
This comment should be correct, currently it is not 👍

tests/qm-connectivity/test.sh Show resolved Hide resolved
tests/e2e/tier-0.fmf Show resolved Hide resolved
@Yarboa
Copy link
Collaborator Author

Yarboa commented May 30, 2023

@cevich
based on your comments, I realize i forgot to add this part of e2e to READM.md of tests
WDYT?

@cevich
Copy link
Member

cevich commented May 30, 2023

to READM.md of tests

Oh my bad, I didn't notice that file. Looking it over...yeah, that would be a better place to include links for non-experts. I wouldn't go too crazy though, since test-readme's are probably at the top of the queue for bit-rot (going out of date quickly). So just some high-level references (like a link to the TMT/FMF docs and maybe the github-action) would be fine by me.

@Yarboa
Copy link
Collaborator Author

Yarboa commented May 30, 2023

to READM.md of tests

Oh my bad, I didn't notice that file. Looking it over...yeah, that would be a better place to include links for non-experts. I wouldn't go too crazy though, since test-readme's are probably at the top of the queue for bit-rot (going out of date quickly). So just some high-level references (like a link to the TMT/FMF docs and maybe the github-action) would be fine by me.

Thanks, for the valuable review 👍 I will update the file

Yarboa added 2 commits May 31, 2023 13:25
@Yarboa
TMT plan to be used by Packit
b364ec9 
Fixes based on test run
Had issues with Array env variables in tmt
Propose some minor changes in e2e/lib/test

Signed-off-by: Yariv Rachmani <[email protected]>
@Yarboa
Adding testingfarm runner
1e75af0 
Adding e2e workflow with centosstream9
As based of comments add tmt as part of packit tests

Signed-off-by: Yariv Rachmani <[email protected]>
@Yarboa
Latest changes based on review
da12f57 
Updates readme with the data related to packit, testingfarm and tmt

Signed-off-by: Yariv Rachmani <[email protected]>
cevich
cevich approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented May 31, 2023

LGTM

@rhatdan rhatdan merged commit c5ff05f into containers:main May 31, 2023
@Yarboa Yarboa deleted the tmt-tests branch July 24, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsm5 lsm5 lsm5 left review comments

@cevich cevich cevich approved these changes

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@dougsland dougsland Awaiting requested review from dougsland dougsland is a code owner

Assignees

@Yarboa Yarboa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yarboa @rhatdan @lsm5 @cevich