Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add libkrun support #679

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] add libkrun support #679

wants to merge 1 commit into from

Conversation

dougsland
Copy link
Collaborator

initial code to add libkrun support

@dougsland
Copy link
Collaborator Author

Hi @giuseppe @slp @rhatdan after running the tool, I still see crun as OCIRuntime via podman info, Am I missing a step?

# podman info| grep -i runtime -A 5
  ociRuntime:
    name: crun
    package: crun-1.19.1-1.fc41.x86_64
    path: /usr/bin/crun
    version: |-
      crun version 1.19.1

initial code to add libkrun support

Signed-off-by: Douglas Schilling Landgraf <[email protected]>
@dougsland
Copy link
Collaborator Author

@slp could you please help us here? Is the patch good anything missing?

@slp
Copy link

slp commented Feb 7, 2025

Hi @dougsland, thanks for working on this.

Even though we require the installation of crun-krun to install the symlink krun -> crun, krun doesn't really have an entity of its own. Calling crun through krun is just a way to let the first know it needs to use libkrun to run the container with virtualization-based isolation, but the OCI runtime is still crun.

On the other hand, we don't want to default to use krun in AutoSD. Instead, the use of krun should be done on selected containers, launched as quadlets, by adding --runtime=krun to PodmanArgs.

@@ -0,0 +1,79 @@
#!/bin/bash
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slp this script is updating container config in qm.container (which we require) and also podman. Is that good solution to your eyes (only enable when running it)?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't think we need to change the runtime globally, but on a per-container basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants