Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github-actions: add test to build dropin targets #620

Merged
merged 2 commits into from
Oct 24, 2024
Merged

github-actions: add test to build dropin targets #620

merged 2 commits into from
Oct 24, 2024

Conversation

dougsland
Copy link
Collaborator

Just test if make dropin targets works

@dougsland
Copy link
Collaborator Author

I am sure soon we will do better validation than that but for now, is good to have something to guarantee we don't break the subpackages.

@Yarboa
Copy link
Collaborator

Yarboa commented Oct 15, 2024

I am sure soon we will do better validation than that but for now, is good to have something to guarantee we don't break the subpackages.

Please explain what is the goal of this PR

@dougsland
Copy link
Collaborator Author

I am sure soon we will do better validation than that but for now, is good to have something to guarantee we don't break the subpackages.

Please explain what is the goal of this PR

Create a github actions to execute a loop to all existing subpackages a

I am sure soon we will do better validation than that but for now, is good to have something to guarantee we don't break the subpackages.

Please explain what is the goal of this PR

Create a github actions that execute make qm_dropin_<NAME_HERE>. Please note <NAME_HERE> is dynamic the number of subpackages can increase or decrease with time.

@dougsland
Copy link
Collaborator Author

dougsland commented Oct 17, 2024 •
edited
Loading

I should be back here soon, just finishing some work in the subpackage of Wayland. If anyone would like to continue this work, feel free. The idea is protect our repo in case we have changes in Makefile that can cause breaks in the builds.

@dougsland dougsland force-pushed the dropin-targets branch 5 times, most recently from 56d501b to feef3a6 Compare October 24, 2024 17:59
@dougsland
Copy link
Collaborator Author

Resolves: #628

@dougsland
github-actions: add test to build dropin targets
c33d612 
Just test if make dropin targets works

Signed-off-by: Douglas Landgraf <[email protected]>
@dougsland dougsland merged commit a194cd2 into main Oct 24, 2024
12 checks passed
@dougsland dougsland deleted the dropin-targets branch November 10, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@lsm5 lsm5 Awaiting requested review from lsm5 lsm5 is a code owner

@Yarboa Yarboa Awaiting requested review from Yarboa Yarboa is a code owner

@sandrobonazzola sandrobonazzola Awaiting requested review from sandrobonazzola sandrobonazzola is a code owner

@nsednev nsednev Awaiting requested review from nsednev nsednev is a code owner

@aesteve-rh aesteve-rh Awaiting requested review from aesteve-rh aesteve-rh is a code owner

@pengshanyu pengshanyu Awaiting requested review from pengshanyu pengshanyu is a code owner

@kleinffm kleinffm Awaiting requested review from kleinffm kleinffm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougsland @Yarboa