Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding VARIABLES for subpackages build #612

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Yarboa
Copy link
Collaborator

@Yarboa Yarboa commented Oct 10, 2024

Adding support in build env vars

This set rpmbuild --define vars in Makefile.
remove define vats for building subpackages

Toggle package to build by define export variable=1

@Yarboa Yarboa marked this pull request as draft October 10, 2024 16:41
@Yarboa Yarboa force-pushed the rpm-subpack branch 3 times, most recently from c69e3a6 to 744fa7c Compare October 10, 2024 20:20
@Yarboa Yarboa marked this pull request as ready for review October 10, 2024 20:21
@dougsland
Copy link
Collaborator

The patch looks good, but CI/CD is complaining, need investigation.

@Yarboa Yarboa force-pushed the rpm-subpack branch 2 times, most recently from d23ec9c to 30935f3 Compare October 14, 2024 09:08
Adding u_variable to be set with default envvars in Makefile
Rebase with main branch
Adding default variables in case not defined

Signed-off-by: Yariv Rachmani <[email protected]>
@Yarboa Yarboa mentioned this pull request Oct 14, 2024
@dougsland dougsland merged commit ba373d0 into containers:main Oct 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants