Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qm.container: add MemoryMax and MemoryHigh #568

Merged
merged 1 commit into from
Sep 13, 2024
Merged

qm.container: add MemoryMax and MemoryHigh #568

merged 1 commit into from
Sep 13, 2024

Conversation

dougsland
Copy link
Collaborator

@dougsland
Copy link
Collaborator Author

@alexlarsson

@alexlarsson
Copy link
Collaborator

I'm not sure why we need this? It changes nothing?

@dougsland
Copy link
Collaborator Author

I'm not sure why we need this? It changes nothing?

Nothing but I am curious about why you guys added here: https://gitlab.com/CentOS/automotive/src/automotive-image-builder/-/merge_requests/102

@alexlarsson
Copy link
Collaborator

The defaults there change nothing, but a manifest for a car can define qm_memory_max=4G, and then it is very useful. I don't think there are any useful values we can hardcode in qm itself though, as we know nothing about the end-user system capacity and expected load.

@dougsland
Copy link
Collaborator Author

The defaults there change nothing, but a manifest for a car can define qm_memory_max=4G, and then it is very useful. I > don't think there are any useful values we can hardcode in qm itself though, as we know nothing about the end-user
system capacity and expected load.

However, it's very useful to all users have a single template from the main qm repo. Today we have auto case but tomorrow we will have more cases for sure. Based on that, I don't think we need a new release but def. merge this one. Sounds good to you too @alexlarsson ?

@alexlarsson
Copy link
Collaborator

I'm not sure what you mean. All this PR is doing is set a few options to their default values. It will change nothing in the behavior. Do you mean that having this in the qm.container file is a kind of documentation for these?

@dougsland
Copy link
Collaborator Author

I'm not sure what you mean. All this PR is doing is set a few options to their default values. It will change nothing in the
behavior. Do you mean that having this in the qm.container file is a kind of documentation for these?

Yes

@alexlarsson
Copy link
Collaborator

Sure, that sounds fine then.

@dougsland dougsland merged commit a5c3abb into main Sep 13, 2024
10 of 11 checks passed
@dougsland dougsland self-assigned this Sep 13, 2024
@dougsland dougsland added the jira label Sep 13, 2024
@dougsland dougsland deleted the infinity branch October 6, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants