-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qm.container: add MemoryMax and MemoryHigh #568
Conversation
Add new settings for [Service] See-Also: https://gitlab.com/CentOS/automotive/src/automotive-image-builder/-/merge_requests/102 Signed-off-by: Douglas Landgraf <[email protected]>
I'm not sure why we need this? It changes nothing? |
Nothing but I am curious about why you guys added here: https://gitlab.com/CentOS/automotive/src/automotive-image-builder/-/merge_requests/102 |
The defaults there change nothing, but a manifest for a car can define |
However, it's very useful to all users have a single template from the main qm repo. Today we have auto case but tomorrow we will have more cases for sure. Based on that, I don't think we need a new release but def. merge this one. Sounds good to you too @alexlarsson ? |
I'm not sure what you mean. All this PR is doing is set a few options to their default values. It will change nothing in the behavior. Do you mean that having this in the qm.container file is a kind of documentation for these? |
Yes |
Sure, that sounds fine then. |
Add new settings for [Service]
See-Also: https://gitlab.com/CentOS/automotive/src/automotive-image-builder/-/merge_requests/102