Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace partprobe with parted #536

Merged
merged 1 commit into from
Sep 6, 2024
Merged

test: replace partprobe with parted #536

merged 1 commit into from
Sep 6, 2024

Conversation

dougsland
Copy link
Collaborator

partprobe requires parted, blockdev uses util-linux-core which most distros ship it in different archs.

@dougsland
Copy link
Collaborator Author

CI/CD shown:

blockdev --rereadpt /dev/nvme1n1p1
blockdev: ioctl error on BLKRRPART: Invalid argument

Basically saying that it won't work in the specify partition, should be the whole disk. Next round will be in the whole disk.

@dougsland
Copy link
Collaborator Author

@Yarboa could you please test downstream? It's all green

@Yarboa
Copy link
Collaborator

Yarboa commented Sep 5, 2024

@Yarboa could you please test downstream? It's all green
I still not sure we need it

still failing
   + blockdev --rereadpt /dev/sde
        blockdev: ioctl error on BLKRRPART: Device or resource busy

@dougsland base on our conversation
for SoC we are not using fdisk,
There is a need to exclude that command once running on SOC

rpm/qm.spec Outdated Show resolved Hide resolved
tests/e2e/lib/diskutils Show resolved Hide resolved
parted is supported in archs we are testing

Signed-off-by: Douglas Landgraf <[email protected]>
@dougsland dougsland force-pushed the blockdev branch 2 times, most recently from 64df265 to 6de6a55 Compare September 5, 2024 13:04
@dougsland dougsland changed the title test: replace partprobe with blockdev test: replace partprobe with parted Sep 5, 2024
@dougsland dougsland force-pushed the blockdev branch 3 times, most recently from 15fbdb2 to 69eb6fe Compare September 5, 2024 14:05
@dougsland
Copy link
Collaborator Author

@Yarboa it's not needed to replace fdisk with parted. Only if you really wanted. parted is able to read the changes from fdisk and update the system. If this patch work, let's merge and make it happen. Later you can decide if you want to proceed with futher improvements or not.

@dougsland
Copy link
Collaborator Author

dougsland commented Sep 5, 2024

Great @Yarboa the patch seems to work? but CI/CD seems not happy with the oom_score_adj again?

PASS: qm.container oom_score_adj value == 500
./test.sh: line 91: [[: /bin/bash: line 1: /proc/0/oom_score_adj: No such file or directory
: syntax error: operand expected (error token is "/bin/bash: line 1: /proc/0/oom_score_adj: No such file or directory
")
FAIL: qm containers oom_score_adj != 750. Current value is '/bin/bash: line 1: /proc/0/oom_score_adj: No such file or directory
'
Shared connection to 3.145.147.198 closed.

@dougsland dougsland merged commit 6b2a7e9 into main Sep 6, 2024
14 of 15 checks passed
@dougsland
Copy link
Collaborator Author

better what we have today.

@dougsland dougsland deleted the blockdev branch September 12, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants