Address pre-commit reported issues

build-aux/validations

@@ -1,10 +1,12 @@
 #!/bin/bash
+
+# shellcheck source=/dev/null
 source /etc/os-release
 
-versionid=$(echo $VERSION_ID | awk -F. '{print $1}')
-id_os=$(echo $ID | grep -i -E "(centos|rhel|autosd)")
+versionid=$(echo "$VERSION_ID" | awk -F. '{print $1}')
+id_os=$(echo "$ID" | grep -i -E "(centos|rhel|autosd)")
 
-if [ "${versionid}" -le 9 ] && [ -n ${id_os} ] ; then
+if [ "${versionid}" -le 9 ] && [ -n "${id_os}" ] ; then
     # the sed command is required for the selinux
     exit 0
 fi

tests/e2e/dashboard-tui/car-dashboard

@@ -150,7 +150,7 @@ class Dashboard(object):
         if returncode != 0:
             print(
                 "{cmd} return code {ret}".format(
-                     cmd=cmd_str, ret=returncode
+                    cmd=cmd_str, ret=returncode
                 )
             )
 
@@ -316,7 +316,7 @@ class Dashboard(object):
         ]
 
         self.execute_cmd(
-                cmd
+            cmd
         )
 
     def make_layout(self) -> Layout:
@@ -421,8 +421,8 @@ class Dashboard(object):
                 padding=(1, 2),
                 title="[b white] " + titleName,
                 border_style="bright_blue",
-             )
-         )
+            )
+        )
 
     def bluechictl_action(
         self,

tests/e2e/set-ffi-env-e2e

@@ -244,9 +244,6 @@ EOF
 
 install_autosd_repo() {
     # Install autosd repository
-    source /etc/os-release
-
-    releasever=${VERSION_ID}
     touch /etc/yum.repos.d/autosd.repo
     cat > "/etc/yum.repos.d/autosd.repo" << EOF
 [autosd]

tests/e2e/tools/FFI/deny_set_scheduler/execute_set_scheduler.c

@@ -6,7 +6,7 @@
 #include <string.h>
 
 int main() {
-    int pid = getpid(); 
+    int pid = getpid();
     int policy = SCHED_FIFO;  // Desired scheduling policy
     struct sched_param param;
 

tests/e2e/tools/FFI/sysctl/setsysctl

@@ -15,21 +15,21 @@ generate_random_number() {
 }
 
 # Network tuning parameters
-sysctl -w net.ipv4.ip_forward=$(generate_random_number 0 1)
-sysctl -w net.ipv4.conf.all.rp_filter=$(generate_random_number 0 2)
-sysctl -w net.ipv4.tcp_max_syn_backlog=$(generate_random_number 128 1024)
+sysctl -w net.ipv4.ip_forward="$(generate_random_number 0 1)"
+sysctl -w net.ipv4.conf.all.rp_filter="$(generate_random_number 0 2)"
+sysctl -w net.ipv4.tcp_max_syn_backlog="$(generate_random_number 128 1024)"
 
 # Buffer Sizes
 if [ -f "/proc/sys/net/core/rmem_max" ]; then
-    sysctl -w net.core.rmem_max=$(generate_random_number 4096 16777216)
+    sysctl -w net.core.rmem_max="$(generate_random_number 4096 16777216)"
 fi
 
 if [ -f "/proc/sys/net/core/wmem_max" ]; then
-    sysctl -w net.core.wmem_max=$(generate_random_number 4096 16777216)
+    sysctl -w net.core.wmem_max="$(generate_random_number 4096 16777216)"
 fi
 
 # Memory management settings
-sysctl -w vm.swappiness=$(generate_random_number 0 100)
-sysctl -w vm.overcommit_memory=$(generate_random_number 0 2)
+sysctl -w vm.swappiness="$(generate_random_number 0 100)"
+sysctl -w vm.overcommit_memory="$(generate_random_number 0 2)"
 
 echo "done"

tests/ffi/deny_sched_setattr/test.sh

@@ -1,5 +1,6 @@
 #!/bin/bash -euvx
 
+# shellcheck source=tests/ffi/common/prepare.sh
 . ../common/prepare.sh
 
 export QM_HOST_REGISTRY_DIR="/var/qm/lib/containers/registry"
@@ -16,6 +17,7 @@ run_container_in_qm "ffi-qm"
 return_from_sched_setattr=$(podman exec -it qm /bin/bash -c \
          'podman exec -it ffi-qm ./QM/execute_sched_setattr')
 
+# shellcheck disable=SC2076
 if [[ "${return_from_sched_setattr}" =~ "${expected_result}" ]]; then
     info_message "QM not allow SCHED_DEADLINE be set via sched_setattr() syscall."
 else

tests/ffi/deny_set_scheduler/test.sh

@@ -1,5 +1,6 @@
 #!/bin/bash -euvx
 
+# shellcheck source=tests/ffi/common/prepare.sh
 . ../common/prepare.sh
 
 export QM_HOST_REGISTRY_DIR="/var/qm/lib/containers/registry"

tests/ffi/qm-oom-score-adj/test.sh

@@ -26,7 +26,7 @@ podman exec -it qm /bin/bash -c \
 QM_PID=$(podman inspect qm --format '{{.State.Pid}}' | tr -d '\r')
 QM_FFI_PID=$(podman exec -it qm /bin/bash -c "podman inspect ffi-qm --format '{{.State.Pid}}'" | tr -d '\r')
 
-QM_OOM_SCORE_ADJ=$(cat /proc/$QM_PID/oom_score_adj)
+QM_OOM_SCORE_ADJ=$(cat "/proc/$QM_PID/oom_score_adj")
 QM_FFI_OOM_SCORE_ADJ=$(podman exec -it qm /bin/bash -c "cat /proc/$QM_FFI_PID/oom_score_adj" | tr -d '\r')
 
 

tests/ffi/sysctl/test.sh

@@ -26,7 +26,7 @@ sysctl_num=$(podman exec qm /bin/bash -c \
 #  - Network subsystem
 #  - Virtual memory subsystem
 SYSCTL_DENIED_COUNT=5
-if [ $sysctl_num -eq "${SYSCTL_DENIED_COUNT}" ];then
+if [ "$sysctl_num" -eq "${SYSCTL_DENIED_COUNT}" ];then
    info_message "Attempt to change OS level are denied successfully inside QM container."
    exit 0
 fi