Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packit: Restore podman-next target list #162

Merged
merged 1 commit into from
Aug 8, 2023
Merged

packit: Restore podman-next target list #162

merged 1 commit into from
Aug 8, 2023

Conversation

martinpitt
Copy link
Contributor

@martinpitt martinpitt commented Aug 8, 2023

I removed them in commit 62c1ee9 with ignoring that this is a deliberate subset of targets, as this project doesn't build in e.g. Fedora 37 or C8S. Put them back.


I was checking recent podman-next builds after the landed packit PRs today, and noticed the build failures. Sorry for the blunder!

This is the net diff of packit.yaml between before PR #160 and this (ignore the tests/e2e bits, that PR landed in between)

@lsm5

I removed them in commit 62c1ee9 with ignoring that this is a
deliberate subset of targets, as this project doesn't build in e.g.
Fedora 37 or C8S. Put them back.

Signed-off-by: Martin Pitt <[email protected]>
@dougsland
Copy link
Collaborator

@lsm5 @sandrobonazzola PTAL

@lsm5
Copy link
Member

lsm5 commented Aug 8, 2023

I was checking recent podman-next builds after the landed packit PRs today, and noticed the build failures. Sorry for the blunder!

My bad. I should have caught that 😞

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsm5
Copy link
Member

lsm5 commented Aug 8, 2023

LGTM'd too soon. We'll need s390x too.

@lsm5
Copy link
Member

lsm5 commented Aug 8, 2023

LGTM'd too soon. We'll need s390x too.

ugh, no it's already there. LGTM final.

@lsm5 lsm5 merged commit 7d9f9db into containers:main Aug 8, 2023
@martinpitt martinpitt deleted the fix-targets branch August 9, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants