Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix pre-commit warnings in bash/python #125

Merged
merged 1 commit into from
Jul 21, 2023
Merged

tests: fix pre-commit warnings in bash/python #125

merged 1 commit into from
Jul 21, 2023

Conversation

dougsland
Copy link
Collaborator

[root@dell730 qm]# pre-commit run --all-files
trim trailing whitespace.................................................Passed
shellcheck...............................................................Passed
markdownlint.............................................................Passed
flake8...................................................................Passed

@dougsland dougsland requested review from rhatdan and lsm5 as code owners July 21, 2023 14:35
@dougsland dougsland requested a review from Yarboa July 21, 2023 14:36
@dougsland
Copy link
Collaborator Author

/cc @sandrobonazzola

@dougsland
Copy link
Collaborator Author

/hold

Need to do the manual tests in the tool.

Signed-off-by: Douglas Schilling Landgraf <[email protected]>
@dougsland
Copy link
Collaborator Author

flake8 output

qm# flake8 tests/e2e/dashboard-tui/car-dashboard
qm#

pre-commit output

qm# pre-commit run --all-files
trim trailing whitespace.................................................Passed
shellcheck...............................................................Passed
markdownlint.............................................................Passed
flake8...................................................................Passed

running e2e tool

qm#> cd tests/e2e
qm#> ./run-test-e2e
# ./run-test-e2e
[ INFO  ] Starting setup
[ INFO  ] ==============================
[ INFO  ] Creating dual stack network
[ INFO  ] Cleaning any previous e2e files

[ INFO  ] Preparing ASIL environment
[ INFO  ] ==============================
[ INFO  ] Creating container control [ASIL mode]. It might take some time...
[ INFO  ] Creating stub systemd service: container-safety in container control. It might take some time...
[ INFO  ] Creating stub systemd service: container-cruise_control in container control. It might take some time...
[ INFO  ] Creating stub systemd service: container-tires in container control. It might take some time...
[ INFO  ] Creating stub systemd service: container-breaks in container control. It might take some time...

[ INFO  ] Preparing QM environment
[ INFO  ] ==============================
[ INFO  ] Creating container node1 [QM mode]
[ INFO  ] Creating stub systemd service: container-radio in node1 and moving it to container qm inside node1
[ INFO  ] Creating stub systemd service: container-store in node1 and moving it to container qm inside node1
[ INFO  ] Creating stub systemd service: container-stream_audio in node1 and moving it to container qm inside node1
[ INFO  ] Creating stub systemd service: container-maps in node1 and moving it to container qm inside node1

[ INFO  ] Starting tests
[ INFO  ] ==============================
[ INFO  ] Waiting hirte containers be ready...

[ INFO  ] #1- Test scenario: hirte list all units from control to node (vise-versa)
[ INFO  ] Connected to control, listing few systemd units from control
NODE                |ID                                                         |   ACTIVE|      SUB
====================================================================================================
control             |dev-disk-by\x2dpartuuid-39fbd751\x2d764c\x2d48ca\x2d8e66\x2|   active|  plugged
control             |run-lock.mount                                             |   active|  mounted
control             |sys-devices-platform-serial8250-tty-ttyS25.device          |   active|  plugged
[ INFO  ] Connected to control, listing few systemd units from node1
NODE                |ID                                                         |   ACTIVE|      SUB
====================================================================================================
node1               |systemd-oomd.service                                       | inactive|     dead
node1               |systemd-tmpfiles-clean.service                             | inactive|     dead
node1               |rescue.service                                             | inactive|     dead
[ INFO  ] Connected to control, listing few systemd units from qm-node1
NODE                |ID                                                         |   ACTIVE|      SUB
====================================================================================================
qm-node1            |systemd-vconsole-setup.service                             | inactive|     dead
qm-node1            |auditd.service                                             | inactive|     dead
qm-node1            |systemd-ask-password-console.service                       | inactive|     dead
[ INFO  ] All set!

dashboard

# e2e> cd dashboard-tui
# dashboard-tui> ./car-dashboard

SCENARIO 1: TYPED in the console: sigstop control safety (WORKED, stop the service in the control node)
SCENARIO 2: TYPED in the console: sigstart control safety (WORKED too)

@dougsland
Copy link
Collaborator Author

CI/CD green, just cosmetic change, safe to merge.

@dougsland dougsland merged commit 83fc1e6 into containers:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant