Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix podman search tests #8220

Closed
wants to merge 1 commit into from
Closed

Conversation

cevich
Copy link
Member

@cevich cevich commented Nov 2, 2020

Depends on #8201

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cevich
To complete the pull request process, please assign tomsweeneyredhat after the PR has been reviewed.
You can assign the PR to them by writing /assign @tomsweeneyredhat in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baude
Copy link
Member

baude commented Nov 2, 2020

we just have an outtage ... i think this is a good thing to search rh registries? what do others think?

An outage caused `registry.redhat.io` to start throwing the error
message indicates a login is now required.  Simplify the hard-coding of
registries for these tests by limiting them to registries we already
rely on extensively elsewhere.  This will make future failures more
obvious, and limit the number of ways in which tests can flake.

Signed-off-by: Chris Evich <[email protected]>
@cevich cevich closed this Nov 3, 2020
@cevich
Copy link
Member Author

cevich commented Nov 3, 2020

ya, probably more important issues for us to focus on.

@cevich cevich deleted the fix_search_tests branch June 30, 2021 18:12
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants