Clicontext #8
Merged
Clicontext #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM, though I'm hesitant to merge before we get PR testing working |
Member
|
Needs a rebase. I believe. |
baude
force-pushed
the
clicontext
branch
3 times, most recently
from
3c6f187 to
b0f1eb6
Compare
Signed-off-by: baude <bbaude@redhat.com>
Create unittests for the create_cli helper functions. As such, remove cli context usage from the functions to further divide between cli input and parsing. Also, simplifies unit testing. Signed-off-by: baude <bbaude@redhat.com>
Add unit tests for func StringInSlice. Signed-off-by: baude <bbaude@redhat.com>
Remove cli context as a func arg to make unit tests easier. Signed-off-by: baude <bbaude@redhat.com>
Unit tests for spec.go which includes testing parts of the oci spec. Signed-off-by: baude <bbaude@redhat.com>
Member
Author
|
if CI passes, please review and/or merge @rhatdan |
rhatdan
reviewed
Nov 4, 2017
libpod/util_test.go
Outdated
| assert.False(t, StringInSlice("five", sliceData)) | ||
| // string is not in empty slice | ||
| assert.False(t, StringInSlice("one", []string{})) | ||
| } No newline at end of file |
Member
Author
There was a problem hiding this comment.
@rhatdan are you wanting a newline? if so, gofmt keeps yanking it out.
Member
|
One Nit, Fix this and then we can merge. LGTM |
Unit tests for getRegistry related functions. Signed-off-by: baude <bbaude@redhat.com>
jwhonce
referenced
this pull request
in jwhonce/podman
Nov 4, 2019
Refactored routing, added more endpoints and types
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_cli_test.go: Unittests
Create unittests for the create_cli helper functions. As
such, remove cli context usage from the functions to
further divide between cli input and parsing. Also, simplifies
unit testing.
vendor in assert package