-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for resource memory limit to generate kube #7913
Add support for resource memory limit to generate kube #7913
Conversation
addresses containers#7855 Signed-off-by: Andy Librian <[email protected]>
/approve |
kubeContainer.SecurityContext = kubeSec | ||
kubeContainer.StdinOnce = false | ||
kubeContainer.TTY = c.config.Spec.Process.Terminal | ||
|
||
if c.config.Spec.Linux != nil && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a TODO for adding CPU limiting support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added. Thanks @mheon.
Signed-off-by: Andy Librian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andylibrian, rhatdan, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Addresses #7855
Steps to run:
Output (see the comment / note in the generated yaml):