Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make image parent check more robust #7554

Merged

Conversation

vrothberg
Copy link
Member

Follow up on issue #7444 and make the parent checks more robust.
We can end up with an incoherent storage when, for instance, a
build has been killed.

Signed-off-by: Valentin Rothberg [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2020
Follow up on issue containers#7444 and make the parent checks more robust.
We can end up with an incoherent storage when, for instance, a
build has been killed.

Signed-off-by: Valentin Rothberg <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Sep 7, 2020

LGTM

@vrothberg
Copy link
Member Author

In case we backport this to 2.0 (we I think we should) we need to cherry-pick commit a6f8586 first.

@vrothberg
Copy link
Member Author

@baude @mheon PTAL

@mheon
Copy link
Member

mheon commented Sep 7, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2020
@vrothberg
Copy link
Member Author

@mheon, can I backport or do we need a BZ?

@openshift-merge-robot openshift-merge-robot merged commit be7778d into containers:master Sep 7, 2020
@mheon
Copy link
Member

mheon commented Sep 7, 2020

At this point, we're very late in the cycle for 8.3 - we can talk at WC tomorrow, but if you think this is necessary we definitely need a BZ.

@vrothberg vrothberg deleted the follow-up-on-7444 branch September 7, 2020 14:55
@vrothberg
Copy link
Member Author

At this point, we're very late in the cycle for 8.3 - we can talk at WC tomorrow, but if you think this is necessary we definitely need a BZ.

Thanks! I created BZ 1876576 👍

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants