-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make image parent check more robust #7554
make image parent check more robust #7554
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Follow up on issue containers#7444 and make the parent checks more robust. We can end up with an incoherent storage when, for instance, a build has been killed. Signed-off-by: Valentin Rothberg <[email protected]>
599370b
to
238abf6
Compare
LGTM |
In case we backport this to 2.0 (we I think we should) we need to cherry-pick commit a6f8586 first. |
/lgtm |
@mheon, can I backport or do we need a BZ? |
At this point, we're very late in the cycle for 8.3 - we can talk at WC tomorrow, but if you think this is necessary we definitely need a BZ. |
Thanks! I created BZ 1876576 👍 |
Follow up on issue #7444 and make the parent checks more robust.
We can end up with an incoherent storage when, for instance, a
build has been killed.
Signed-off-by: Valentin Rothberg [email protected]