Skip to content

WIP: move to sysregistriesv2 #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vrothberg wants to merge 1 commit into from
Closed

WIP: move to sysregistriesv2 #709

vrothberg wants to merge 1 commit into from

Conversation

@vrothberg
Copy link
Member

@vrothberg vrothberg commented May 2, 2018

Work in progress...

Signed-off-by: Valentin Rothberg vrothberg@suse.com

@vrothberg
WIP: move to sysregistriesv2
3b12aa8 
Signed-off-by: Valentin Rothberg <vrothberg@suse.com>
@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented May 7, 2018

☔ The latest upstream changes (presumably faa8c3e) made this pull request unmergeable. Please resolve the merge conflicts.

@rhatdan
Copy link
Member

rhatdan commented Jun 27, 2018

@vrothberg Can we get this one moving again now?

@vrothberg
Copy link
Member Author

vrothberg commented Jun 27, 2018 •
edited
Loading

@vrothberg Can we get this one moving again now?

It is moving, but all work is being done in containers/image at the moment. The sysregistriesv2 package has been updated, and currently we're sorting out some rough edges regarding TLS verification. Once that's done, the pull code from libpod and buildah goes into containers/image/docker. Then we can update libpod, buildah and skopeo and all will have sysregsv2 support including mirrors etc.

@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented Aug 13, 2018

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@mheon
Copy link
Member

mheon commented Aug 13, 2018

bot, add author to whitelist

@rhatdan
Copy link
Member

rhatdan commented Nov 27, 2018

@vrothberg Needs a rebase.

@openshift-bot
Copy link

openshift-bot commented Dec 3, 2018

@vrothberg: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2018
@vrothberg
Copy link
Member Author

vrothberg commented Dec 4, 2018

We can finally close this one. There's #1930 now, which does all the integration.

@vrothberg vrothberg closed this Dec 4, 2018
@vrothberg vrothberg deleted the sysregistriesv2 branch December 4, 2018 15:17
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@vrothberg vrothberg

Labels

locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vrothberg @rh-atomic-bot @rhatdan @mheon @openshift-bot @jwhonce @openshift-ci-robot