Fixes --remote flag issues #6716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
vrothberg
reviewed
Jun 23, 2020
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwhonce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jwhonce
force-pushed
the
issues/6598
branch
3 times, most recently
from
6fd57fe to
350d89e
Compare
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
@jwhonce Tests are not happy. |
jwhonce
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
jwhonce
force-pushed
the
issues/6598
branch
4 times, most recently
from
7b5c11c to
74b4159
Compare
jwhonce
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
* --remote, --url and --identity are now anchored to podman command. Subcommands should no longer have issues * TraverseChildren now set to V1 expectations * Latest flag now has helper function. Now has consistent usage. * IsRemote() uses cobra parser to determin if --remote is given * Moved validation functions from parser pkg to validate pkg * Fixes containers#6598 Fixes containers#6704 Signed-off-by: Jhon Honce <[email protected]>
|
LGTM |
jwhonce
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6598
Fixes #6704
Signed-off-by: Jhon Honce [email protected]