rootless_linux: improve error message #6703
Conversation
openshift-ci-robot
added
the
needs-ok-to-test
|
Hi @dougsland. Thanks for your PR. I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/rootless/rootless_linux.go
Outdated
| @@ -166,7 +166,8 @@ func GetConfiguredMappings() ([]idtools.IDMap, []idtools.IDMap, error) { | |||
| } | |||
| mappings, err := idtools.NewIDMappings(username, username) | |||
| if err != nil { | |||
| logrus.Errorf("cannot find mappings for user %s: %v", username, err) | |||
| logrus.Errorf( | |||
| "cannot find mappings for user %s: %v, examine rootless mode in man podman", username, err) | |||
There was a problem hiding this comment.
This is used by more than just Podman, so this should probably be reworded - maybe cannot find UID/GID mappings for user %s: %v - check /etc/subuid and /etc/subgid?
There was a problem hiding this comment.
@mheon how about:
"cannot find UID/GID for user %s: %v - check rootless mode in the official documentation"
There was a problem hiding this comment.
I would be more specific. check rootless mode in man pages.
Improve the error message for rootless mode. Git-Url: #6572 Signed-off-by: Douglas Schilling Landgraf <[email protected]>
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougsland, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Thanks for contributing! |
github-actions
bot
added
the
locked - please file new issue/PR
Improve the error message for rootless mode.
Git-Url: #6572
Signed-off-by: Douglas Schilling Landgraf [email protected]