Add support for pid ns #54
Conversation
|
Sign this please @rhatdan |
cmd/kpod/spec.go
Outdated
| } | ||
| return libpod.ErrNotImplemented | ||
| /* | ||
| pidNsPath := fmt.Sprintf("/proc/%d/ns/pid", state.Pid) |
There was a problem hiding this comment.
Is this commented code needed or will it be added shortly? A TODO comment maybe if it's going to stay?
|
Any changes/additions to the tests needed? |
|
Yes I will add tests. |
|
@rhatdan We have support baked into libpod for sharing namespaces, though it's not turned on yet - see https://github.com/projectatomic/libpod/blob/master/libpod/options.go#L300-L307 |
rhatdan
force-pushed
the
pidns
branch
4 times, most recently
from
e78247d to
c5be531
Compare
|
@TomSweeneyRedHat @mheon @umohnani8 @baude PTAL Tests passing. |
|
LGTM |
|
Removed the TODO and added handling of the state.PID call for --pid containers:UUID. |
cmd/kpod/spec.go
Outdated
| @@ -17,6 +17,27 @@ import ( | |||
| "golang.org/x/sys/unix" | |||
| ) | |||
|
|
|||
| func addPidNS(config *createConfig, g *generate.Generator) error { | |||
There was a problem hiding this comment.
Can you add a TODO here to switch to the libpod support for sharing namespaces when that lands?
|
One nit, otherwise LGTM. Tests are failing though. |
rhatdan
force-pushed
the
pidns
branch
2 times, most recently
from
8fc94da to
6eaf390
Compare
|
LGTM |
|
☔ The latest upstream changes (presumably 91b406e) made this pull request unmergeable. Please resolve the merge conflicts. |
rhatdan
force-pushed
the
pidns
branch
2 times, most recently
from
2618cae to
7559a18
Compare
Signed-off-by: Daniel J Walsh <[email protected]>
|
@rh-atomic-bot r=umohnani8 |
|
📌 Commit 38a49d2 has been approved by |
|
☀️ Test successful - status-papr |
Release: clean the builddir when building
github-actions
bot
added
the
locked - please file new issue/PR
5 participants
No description provided.