Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate systemd: add network dependencies #5382

Merged
merged 1 commit into from
Mar 5, 2020
Merged

generate systemd: add network dependencies #5382

merged 1 commit into from
Mar 5, 2020

Conversation

vrothberg
Copy link
Member

Add network dependencies to generated systemd services to allow for
enabling them at system startup and have a working network if needed.

Fixes: #4130
Signed-off-by: Valentin Rothberg [email protected]

@vrothberg
generate systemd: add network dependencies
05a0bf7 
Add network dependencies to generated systemd services to allow for
enabling them at system startup and have a working network if needed.

Fixes: containers#4130
Signed-off-by: Valentin Rothberg <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

@vrothberg: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/images 05a0bf7 link /test images

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2020
@rhatdan
Copy link
Member

rhatdan commented Mar 3, 2020

LGTM

@vrothberg
Copy link
Member Author

Note that this will allow the services to be enabled and start at system boot. networ-online.target is sufficient (at least for root). Will further investigate rootless.

@baude @giuseppe PTAL

@vrothberg vrothberg mentioned this pull request Mar 5, 2020
Closed
@giuseppe
Copy link
Member

giuseppe commented Mar 5, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2020
@openshift-merge-robot openshift-merge-robot merged commit 9ffc525 into containers:master Mar 5, 2020
@vrothberg vrothberg mentioned this pull request Mar 9, 2020
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe Awaiting requested review from giuseppe

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@giuseppe giuseppe

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generate systemd: add network dependency
5 participants
@vrothberg @openshift-ci-robot @rhatdan @giuseppe @openshift-merge-robot