support device-cgroup-rule #5152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QiWang19
force-pushed
the
device-cgroup-rule
branch
2 times, most recently
from
e2fca22 to
dd5b8ba
Compare
|
@QiWang19 the new tests are not happy |
QiWang19
force-pushed
the
device-cgroup-rule
branch
4 times, most recently
from
14d6bd0 to
1b93eeb
Compare
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon, QiWang19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
LGTM once tests go green |
|
LGTM |
QiWang19
force-pushed
the
device-cgroup-rule
branch
from
1b93eeb to
35d11c8
Compare
fix containers#4876 Add `--device-cgroup-rule` to podman create and run. This enables to add device rules after the container has been created. Signed-off-by: Qi Wang <[email protected]>
QiWang19
force-pushed
the
device-cgroup-rule
branch
from
35d11c8 to
d326073
Compare
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4876
Add
--device-cgroup-ruleto podman create and run. This enables to add device rules after the container has been created.Signed-off-by: Qi Wang [email protected]