Add .papr support #5
Conversation
|
CI is running, this is very promising |
rhatdan
force-pushed
the
master
branch
2 times, most recently
from
63bb055 to
c91c78c
Compare
|
baaa...lessee whahappeeen... |
yourfault.../me runs away 😀 (srsly, giving a once-over of changes here...) |
|
We're doing install.tools which should grab the linter. Maybe it's in the wrong place? |
|
No idea why this closed. |
|
I don't have permission to reopen - you're repo owner |
cevich
left a comment
cevich
left a comment
There was a problem hiding this comment.
Some things to thinkabout at least...
.papr.sh
Outdated
|
|
||
| export GOPATH=$HOME/gopath | ||
| export PATH=$HOME/gopath/bin:$PATH | ||
| export GOSRC=$HOME/gopath/src/github.com/projectatomic/libpod |
There was a problem hiding this comment.
Hmm, is $HOME appropriate here? I dunno what "user" is running the job or where it starts from. Maybe I'm wrong though, it's worth double checking.
There was a problem hiding this comment.
This was copied from buildah, I think in CI this will be /root
.papr.sh
Outdated
|
|
||
| (mkdir -p $GOSRC && cd /code && cp -r . $GOSRC) | ||
|
|
||
| dnf install -y \ |
There was a problem hiding this comment.
I this ever going to run against a RHEL system? Hmmm....n/m it's probably not a problem that needs solving now.
.papr.sh
Outdated
|
|
||
| # PAPR adds a merge commit, for testing, which fails the | ||
| # short-commit-subject validation test, so tell git-validate.sh to only check | ||
| # up to, but not including, the merge commit. |
.papr.sh
Outdated
| # short-commit-subject validation test, so tell git-validate.sh to only check | ||
| # up to, but not including, the merge commit. | ||
| export GITVALIDATE_TIP=$(cd $GOSRC; git log -2 --pretty='%H' | tail -n 1) | ||
| export TAGS="seccomp $(hack/btrfs_tag.sh) $(hack/libdm_tag.sh) $(hack/btrfs_installed_tag.sh) $(hack/ostree_tag.sh) $(hack/selinux_tag.sh)" |
There was a problem hiding this comment.
As an old-fuddy-duddy, I like having all my "constants" all at the beginning, so I always know where to find them. I dunno though for this context, maybe that doesn't make sense.
There was a problem hiding this comment.
No problem moving but again this came from buildah. We should probably be consistent.
.papr.yml
Outdated
| branches: | ||
| - master | ||
| - auto | ||
| - try |
There was a problem hiding this comment.
Hmm, not sure why you need anything other than 'master'.
There was a problem hiding this comment.
Me neither. I will remove auto and try.
There was a problem hiding this comment.
(Mostly we just use the auto branch - when doing a merge, it pushes there first and waits for PAPR to report)
There was a problem hiding this comment.
What's a "homu"? Can you eat it? 😀
@rhatdan I checked the docs, this is just the branches to test, so just 'master' is appropriate here since none of the other branches exist.
/me still wonders what a homu is
There was a problem hiding this comment.
There was a problem hiding this comment.
@cevich Homu will create those branches when doing a merge.
There was a problem hiding this comment.
Ooohhh, https://github.com/servo/homu/ it's a service. gotcha, kk, I'll put those back and add a comment 😀
Makefile
Outdated
| @@ -146,7 +146,7 @@ install.man: | |||
| install ${SELINUXOPT} -m 644 $(filter %.8,$(MANPAGES)) -t $(MANDIR)/man8 | |||
|
|
|||
| install.config: | |||
| install ${SELINUXOPT} -D -m 644 seccomp.json $(ETCDIR_CRIO)/seccomp.json | |||
| install ${SELINUXOPT} -D -m 644 seccomp.json $(ETCDIR_LIBPOD)/seccomp.json | |||
| install ${SELINUXOPT} -D -m 644 crio-umount.conf $(OCIUMOUNTINSTALLDIR)/crio-umount.conf | |||
|
|
|||
| install.completions: | |||
plugins: add plugins from containernetworking/cni
github-actions
bot
added
the
locked - please file new issue/PR
4 participants
Signed-off-by: Daniel J Walsh dwalsh@redhat.com