Skip to content

Update build man page with latest Buildah changes#4201

Merged
openshift-merge-robot merged 1 commit intocontainers:masterfrom
TomSweeneyRedHat:dev/tsweeney/updatebuildmd
Oct 11, 2019
Merged

Update build man page with latest Buildah changes#4201
openshift-merge-robot merged 1 commit intocontainers:masterfrom
TomSweeneyRedHat:dev/tsweeney/updatebuildmd

Conversation

@TomSweeneyRedHat
Copy link
Member

Changes include: Containerfile by default, add --device flags to bud, allow podman build to be called without arguments, and a couple of small typo corrections.

Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M labels Oct 4, 2019
@TomSweeneyRedHat
Copy link
Member Author

@mheon @baude, this needs to be merged before the next Podman release is created.

@TomSweeneyRedHat
Copy link
Member Author

TomSweeneyRedHat commented Oct 5, 2019

I'm getting bit by the title change. Should I change hack/man-page-checker or can we smash this in?

[+0043s] ./hack/man-page-checker
[+0044s] 
[+0044s] Inconsistent subcommand descriptions:
[+0044s]   podman-build.1.md                = 'Build a container image using a Containerfile'
[+0044s]   podman.1.md                      = 'Build a container image using a Dockerfile'
[+0044s] Please ensure that the NAME section of podman-build.1.md
[+0044s] matches the subcommand description in podman.1.md
[+0046s] make: *** [Makefile:326: man-page-check] Error 1

@rhatdan
Copy link
Member

rhatdan commented Oct 6, 2019

You need to change the podman.1.md to match podman-build.1.md.

@rhatdan
Copy link
Member

rhatdan commented Oct 6, 2019

LGTM
other then fixing the podman man page.

We really should change

./bin/podman build --help
Build an image using instructions from Dockerfiles

Description:
  Builds an OCI or Docker image using instructions from one or more Dockerfiles and a specified build context directory.

Usage:
  podman build [flags] CONTEXT

Examples:
  podman build .
  podman build --creds=username:password -t imageName -f Dockerfile.simple .
  podman build --layers --force-rm --tag imageName .

Which might cause issues with this PR as well. Since I think the description up top needs to match the description in the man page.

@TomSweeneyRedHat
Copy link
Member Author

@rhatdan touched up the internal and podman.1.md too. Hopefully that will cure my man-page-checker blues. Thx.

@rhatdan
Copy link
Member

rhatdan commented Oct 7, 2019

Seems like crun tests are very sick. @giuseppe Is this the bug you are fixing?

@rhatdan
Copy link
Member

rhatdan commented Oct 7, 2019

LGTM, but don't know how we fix the crun issues.

Changes include: Containerfile by default, add --device flags to bud, allow buildah bud to be called without
arguments, and a couple of small typo corrections.

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
@TomSweeneyRedHat
Copy link
Member Author

I'd some issue in an image test that I couldn't make go away. I've rebased in hopes of a cure.

@rhatdan
Copy link
Member

rhatdan commented Oct 11, 2019

@mheon @baude @giuseppe @vrothberg @QiWang19 @jwhonce PTAL
Lets get this merged.

@QiWang19
Copy link
Member

LGTM

@rhatdan
Copy link
Member

rhatdan commented Oct 11, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2019
@openshift-merge-robot openshift-merge-robot merged commit cd167fc into containers:master Oct 11, 2019
@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/updatebuildmd branch January 8, 2020 18:37
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants