Update build man page with latest Buildah changes#4201
Update build man page with latest Buildah changes#4201openshift-merge-robot merged 1 commit intocontainers:masterfrom TomSweeneyRedHat:dev/tsweeney/updatebuildmd
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I'm getting bit by the title change. Should I change hack/man-page-checker or can we smash this in? |
|
You need to change the podman.1.md to match podman-build.1.md. |
|
LGTM We really should change Which might cause issues with this PR as well. Since I think the description up top needs to match the description in the man page. |
|
@rhatdan touched up the internal and podman.1.md too. Hopefully that will cure my man-page-checker blues. Thx. |
|
Seems like crun tests are very sick. @giuseppe Is this the bug you are fixing? |
|
LGTM, but don't know how we fix the crun issues. |
Changes include: Containerfile by default, add --device flags to bud, allow buildah bud to be called without arguments, and a couple of small typo corrections. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
|
I'd some issue in an image test that I couldn't make go away. I've rebased in hopes of a cure. |
|
LGTM |
|
/lgtm |
Changes include: Containerfile by default, add --device flags to bud, allow podman build to be called without arguments, and a couple of small typo corrections.
Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com