-
Notifications
You must be signed in to change notification settings - Fork 3k
Update buildah to v1.11.0 #3948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update buildah to v1.11.0 #3948
Conversation
Vendor in the latest changes for buildah to apply the implemented features here as well. Signed-off-by: Sascha Grunert <[email protected]>
|
LGTM pending green tests |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@saschagrunert Can I be a complete PITA and ask you to revendor Buildah for this PR? I messed up and we'd some tag mess-ups with Buildah for v1.11.0 that were just straightened out, I think after you did this vendoring. |
|
/hold |
Hm, I get no changes If I run |
|
@saschagrunert thanks for checking. I'd just had the brilliant idea, one that I should have had earlier, to check the file changes from Buildah in here. You don't have the changes that were added after 1.11.0 was created, only the ones that I'd expect for v1.11.0. This looks to be correct, I'll cancel the hold. Thanks again for looking and apologies for the churn. |
|
/hold cancel |
|
LGTM |
|
/lgtm |
Vendor in the latest changes for buildah to apply the implemented
features here as well.