Improve DESTDIR/PREFIX/ETCDIR handling

[llchan]

We install our podman in a non-standard prefix, e.g. PREFIX=/path/to/podman-1.3.1, and during the installation process we stage the files in a DESTDIR=/path/to/sandbox. This changeset makes the DESTDIR apply even if PREFIX is specified. It also makes the constants in the binary prefix-aware, so it's able to find its own conf files rather than the hardcoded /usr/local path. We could also make it search by relative path to the binary, but that's a little more involved.

One thing to note is that some of the constants were converted to vars so that they can be overridden at build time. I don't think this should be an issue, but worth mentioning.

Work in progress, just wanted to push this up for comments/discussion.

[openshift-ci-robot]

Hi @llchan. Thanks for your PR.

I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mheon]

I don't know if I like version.go for the prefixes (runtime.go would keep everything in one place), but overall I have no problems with this - though I suspect there are a lot of lingering hardcoded /etc/ and /usr/share paths strewn throughout the code.

[rh-atomic-bot]

Can one of the admins verify this patch?
I understand the following commands:

• bot, add author to whitelist
• bot, test pull request
• bot, test pull request once

[llchan]

Yeah, I actually had it originally in runtime.go, but stuck it in version.go to sit alongside the other build-time constants. Can easily move it if that's preferred.

[llchan]

Also FYI, my heuristic for which paths to touch was "can the Makefile install something to this path", so stuff like runc/conmon paths were left alone, but the podman config files were made relative to the install prefix. I wasn't quite sure what to do with the cataonit stuff so I left it alone. Once we make the catatonit install less hacky and have it respect the Makefile PREFIX, I think we should also make the default init path relative.

[rh-atomic-bot]

☔ The latest upstream changes (presumably #3282) made this pull request unmergeable. Please resolve the merge conflicts.

[rhatdan]

@llchan Needs a rebase.

[rhatdan]

LGTM

[llchan]

Rebased and re-pushed, and added missing sign-off to the second commit. Can squash if preferred.

[rhatdan]

Go Lint does not like the string here.
installPrefix = "/usr/local"
is preferred.

[llchan]

Fixed, and updated my vim setup to lint in the future.

[rhatdan]

Go Lint does not like the string here.
etcDir = "/etc"
is preferred.

[llchan]

Fixed

[mheon]

/ok-to-test
/approve
LGTM

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: llchan, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

/lgtm
/hold

[rh-atomic-bot]

☔ The latest upstream changes (presumably #3328) made this pull request unmergeable. Please resolve the merge conflicts.

[llchan]

Rebased

[rhatdan]

/lgtm

[rhatdan]

/hold cancel