-
Notifications
You must be signed in to change notification settings - Fork 3k
Cirrus: Temp. workaround VFS incompatible option #3239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cevich If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@mheon @edsantiago PTAL |
|
This is covering up a real bug. |
|
@rhatdan I chatted with @mheon and @edsantiago about this yesterday morning. I believe Matt opened a containers/storage issue covering a good idea that Ed had:
Though your idea in #3240 could be a compromise. My intention here is only a temporary fix, to be reverted later. This problem is blocking us from moving up to testing with Fedora 30. We also risk mass-breakage in F29 should they pick up the latest containers-common package. I'll leave it up to y'all to work out, no worries if we just close this PR in favor of another fix. |
|
/hold |
|
Ugg, more workarounds needed for podman-in-podman as well. I'll attempt that, and --force push on the off-chance we actually need this PR. |
There are many integration tests using the VFS storage driver. A recent update to the containers-common package in Fedora added a new mount option `metacopy=on` as it enhances security. However, this option is not compatible with the VFS storage driver, causing those tests to fail. Until a better solution is realized, workaround this problem by forcing "nodev" as the only mount option on all platforms. Also add a visible note to the output flagging the change. Signed-off-by: Chris Evich <cevich@redhat.com>
There are many integration tests using the VFS storage driver. A
recent update to the containers-common package in Fedora added a new
mount option
metacopy=onas it enhances security. However, this optionis not compatible with the VFS storage driver, causing those tests to
fail.
Until a better solution is realized, workaround this problem by forcing
"nodev" as the only mount option on all platforms. Also add a visible
note to the output flagging the change.
Signed-off-by: Chris Evich cevich@redhat.com