Skip to content

split rootless local and remote testing #3236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 1, 2019
Merged

split rootless local and remote testing #3236

openshift-merge-robot merged 1 commit into from
Jun 1, 2019

Conversation

@baude
Copy link
Member

@baude baude commented May 30, 2019

Signed-off-by: baude bbaude@redhat.com

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2019
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS labels May 30, 2019
@baude baude force-pushed the testsplitrootless branch 2 times, most recently from 52f3b51 to c5dad65 Compare May 30, 2019 16:06
@baude baude force-pushed the testsplitrootless branch 3 times, most recently from d115210 to ca9feb5 Compare May 30, 2019 19:14
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2019
@baude baude force-pushed the testsplitrootless branch from ca9feb5 to 353e6b2 Compare May 30, 2019 19:16
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2019
@baude baude force-pushed the testsplitrootless branch 2 times, most recently from 0999cd2 to 0631d12 Compare May 30, 2019 20:12
@edsantiago edsantiago mentioned this pull request May 30, 2019
Merged
@baude baude force-pushed the testsplitrootless branch 3 times, most recently from 2199241 to 128d672 Compare May 31, 2019 17:41
@baude baude changed the title [wip] split rootless local and remote testing split rootless local and remote testing May 31, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2019
@baude
Copy link
Member Author

baude commented May 31, 2019

It looks like this really helped standardize test times. Remember this is without the caching benefits as it hadn't been merged yet and I have not rebased due to test issues: Here are some results:

rootless
  local 18:47
  remote 20:99
in_podmn
  local 24:17
f28
  local 20:57
  remote 20:53
f29
  local 21:44
  remote 21:22
ubuntu
  local 21:48
  remote 25:08

And I believe that caching cut the local test times in just about one-half.

@mheon
Copy link
Member

mheon commented May 31, 2019

LGTM

cevich
cevich reviewed May 31, 2019
View reviewed changes
@baude
split rootless local and remote testing
d1c44ea 
Signed-off-by: baude <bbaude@redhat.com>
@baude baude force-pushed the testsplitrootless branch from 128d672 to d1c44ea Compare May 31, 2019 19:54
@cevich
Copy link
Member

cevich commented May 31, 2019

Oh, crap...I almost forgot: the docs 😕

@cevich
Copy link
Member

cevich commented May 31, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2019
@cevich
Copy link
Member

cevich commented May 31, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2019
@baude
Copy link
Member Author

baude commented Jun 1, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2019
@openshift-merge-robot openshift-merge-robot merged commit 2068919 into containers:master Jun 1, 2019
This was referenced Jun 1, 2019
Merged
Merged
Merged
@baude baude deleted the testsplitrootless branch December 22, 2019 19:13
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@rhatdan rhatdan Awaiting requested review from rhatdan

1 more reviewer

@cevich cevich cevich left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@cevich cevich

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@baude @openshift-ci-robot @mheon @cevich @openshift-merge-robot