Skip to content

oci: fix race when the container exits before start returns #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
giuseppe wants to merge 1 commit into from
Closed

oci: fix race when the container exits before start returns #3125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions libpod/container_internal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,6 +1029,13 @@ func (c *Container) start() error {

c.state.State = ContainerStateRunning

// While we hold the lock, ensure the container is still running.
// The container could have already stopped by the time "$runtime start"
// exits and we mistakenly report it as "running".
if err := c.runtime.state.UpdateContainer(c); err != nil {
return err
}

if c.config.HealthCheckConfig != nil {
if err := c.updateHealthStatus(HealthCheckStarting); err != nil {
logrus.Error(err)
Expand Down