Skip to content

Conversation

@vrothberg
Copy link
Member

  • move to go modules
  • fix ErrUnkownDescriptor typo
  • catch errors of Setns()

Signed-off-by: Valentin Rothberg rothberg@redhat.com

* move to go modules
* fix ErrUnkownDescriptor typo
* catch errors of Setns()

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S labels Apr 26, 2019
@vrothberg
Copy link
Member Author

@rhatdan PTAL

Once that's merged we can do the top dance.

@rhatdan
Copy link
Member

rhatdan commented Apr 26, 2019

@mheon
Copy link
Member

mheon commented Apr 26, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2019
@openshift-merge-robot openshift-merge-robot merged commit 135c8be into containers:master Apr 26, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants